Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 111463009: Replace parts of WebMediaPlayerParams with WebMediaPlayerImpl accessing RenderThreadImpl directly. (Closed)

Created:
7 years ago by scherkus (not reviewing)
Modified:
7 years ago
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Replace parts of WebMediaPlayerParams with WebMediaPlayerImpl accessing RenderThreadImpl directly. Using WebMediaPlayerParams to pass a MessageLoopProxy, GpuVideoAcceleratorFactories, and MediaLog was more useful when WebMediaPlayerImpl lived in src/webkit/media/. These days it's unnecessary. TBR=jamesr Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242030

Patch Set 1 : #

Total comments: 2

Patch Set 2 : remove MediaLog #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -48 lines) Patch
M content/renderer/media/webmediaplayer_impl.cc View 1 4 chunks +6 lines, -3 lines 0 comments Download
M content/renderer/media/webmediaplayer_params.h View 1 3 chunks +2 lines, -28 lines 0 comments Download
M content/renderer/media/webmediaplayer_params.cc View 1 1 chunk +3 lines, -13 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
scherkus (not reviewing)
alternatively I can nuke WMPParams entirely
7 years ago (2013-12-19 18:20:08 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm https://codereview.chromium.org/111463009/diff/20001/content/renderer/render_view_impl.cc File content/renderer/render_view_impl.cc (right): https://codereview.chromium.org/111463009/diff/20001/content/renderer/render_view_impl.cc#newcode3016 content/renderer/render_view_impl.cc:3016: new RenderMediaLog()); Could this me moved into WMPI ...
7 years ago (2013-12-19 22:42:25 UTC) #2
scherkus (not reviewing)
https://codereview.chromium.org/111463009/diff/20001/content/renderer/render_view_impl.cc File content/renderer/render_view_impl.cc (right): https://codereview.chromium.org/111463009/diff/20001/content/renderer/render_view_impl.cc#newcode3016 content/renderer/render_view_impl.cc:3016: new RenderMediaLog()); On 2013/12/19 22:42:25, acolwell wrote: > Could ...
7 years ago (2013-12-19 22:59:39 UTC) #3
scherkus (not reviewing)
7 years ago (2013-12-19 23:00:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/111463009/40001
7 years ago (2013-12-19 23:07:26 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=42376
7 years ago (2013-12-19 23:42:48 UTC) #6
scherkus (not reviewing)
TBR=jamesr for content/renderer/* changes
7 years ago (2013-12-19 23:48:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/111463009/40001
7 years ago (2013-12-19 23:49:32 UTC) #8
commit-bot: I haz the power
7 years ago (2013-12-20 07:37:29 UTC) #9
Message was sent while issue was closed. 
Change committed as 242030

Powered by Google App Engine
This is Rietveld 408576698