Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4196)

Unified Diff: chrome/browser/prerender/prerender_browsertest.cc

Issue 1114623002: Plugin Power Saver: Make PPS work well with prerendered pages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_browsertest.cc
diff --git a/chrome/browser/prerender/prerender_browsertest.cc b/chrome/browser/prerender/prerender_browsertest.cc
index 91783116f510c7121e51ecedaea953d15516ef78..a1abe4a35c2e8b895c556a724c1573d8be4c8416 100644
--- a/chrome/browser/prerender/prerender_browsertest.cc
+++ b/chrome/browser/prerender/prerender_browsertest.cc
@@ -103,6 +103,7 @@
#include "net/url_request/url_request_filter.h"
#include "net/url_request/url_request_interceptor.h"
#include "net/url_request/url_request_job.h"
+#include "ppapi/shared_impl/ppapi_switches.h"
#include "ui/base/l10n/l10n_util.h"
#include "url/gurl.h"
@@ -1108,7 +1109,9 @@ class PrerenderBrowserTest : virtual public InProcessBrowserTest {
void SetUpCommandLine(base::CommandLine* command_line) override {
command_line->AppendSwitchASCII(switches::kPrerenderMode,
switches::kPrerenderModeSwitchValueEnabled);
- ASSERT_TRUE(ppapi::RegisterTestPlugin(command_line));
+ command_line->AppendSwitch(switches::kEnablePepperTesting);
+
+ ASSERT_TRUE(ppapi::RegisterPowerSaverTestPlugin(command_line));
}
void SetUpOnMainThread() override {
@@ -1968,8 +1971,8 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, PrerenderAlertAfterOnload) {
// Checks that plugins are not loaded while a page is being preloaded, but
// are loaded when the page is displayed.
IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, PrerenderDelayLoadPlugin) {
- PrerenderTestURL("files/prerender/plugin_delay_load.html", FINAL_STATUS_USED,
- 1);
+ PrerenderTestURL("files/prerender/prerender_plugin_delay_load.html",
+ FINAL_STATUS_USED, 1);
NavigateToDestURL();
}
@@ -1981,9 +1984,16 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, PrerenderContentSettingDetect) {
content_settings_map->SetDefaultContentSetting(
CONTENT_SETTINGS_TYPE_PLUGINS, CONTENT_SETTING_DETECT_IMPORTANT_CONTENT);
- PrerenderTestURL("files/prerender/plugin_delay_load.html", FINAL_STATUS_USED,
- 1);
+ PrerenderTestURL("files/prerender/prerender_plugin_power_saver.html",
+ FINAL_STATUS_USED, 1);
+
+ DisableJavascriptCalls();
NavigateToDestURL();
+ bool second_placeholder_present = false;
+ ASSERT_TRUE(content::ExecuteScriptAndExtractBool(
+ GetActiveWebContents(), "AwaitPluginPrerollAndPlaceholder();",
+ &second_placeholder_present));
+ EXPECT_TRUE(second_placeholder_present);
}
// For Content Setting BLOCK, checks that plugins are never loaded.
@@ -1993,8 +2003,8 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, PrerenderContentSettingBlock) {
content_settings_map->SetDefaultContentSetting(CONTENT_SETTINGS_TYPE_PLUGINS,
CONTENT_SETTING_BLOCK);
- PrerenderTestURL("files/prerender/plugin_never_load.html", FINAL_STATUS_USED,
- 1);
+ PrerenderTestURL("files/prerender/prerender_plugin_never_load.html",
+ FINAL_STATUS_USED, 1);
NavigateToDestURL();
}
« no previous file with comments | « chrome/browser/plugins/plugin_power_saver_browsertest.cc ('k') | chrome/renderer/chrome_content_renderer_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698