chrome/renderer/chrome_content_renderer_client.cc - Issue 1114623002: Plugin Power Saver: Make PPS work well with prerendered pages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 1114623002: Plugin Power Saver: Make PPS work well with prerendered pages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/prerender/prerender_browsertest.cc ('k') | chrome/renderer/plugins/chrome_plugin_placeholder.h » ('j') | chrome/test/data/prerender/prerender_plugin_delay_load.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/chrome_content_renderer_client.cc

diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc

index ad8fee16a7ce064a1fdf89be4f3ec1648b929ef2..d121c6cde3cf89003e3b78f74c3e70f79d264631 100644

--- a/chrome/renderer/chrome_content_renderer_client.cc

+++ b/chrome/renderer/chrome_content_renderer_client.cc

@@ -850,16 +850,12 @@ WebPlugin* ChromeContentRendererClient::CreatePlugin(

bool is_prerendering =

prerender::PrerenderHelper::IsPrerendering(render_frame);

- // TODO(tommycli): Plugin Power Saver is disabled on prerendered pages.

+ // TODO(tommycli): Background tab plugin deferral is disabled.

// This is because the placeholder does not feed back into

// ChromeContentRendererClient::CreatePlugin. Because of this, it does

// not handle the preroll to UI overlay placeholder flow correctly.

- //

- // Background tab plugin deferral is disabled for the same reason.

- //

// https://crbug.com/471427

bool power_saver_enabled =

- !is_prerendering &&

status ==

ChromeViewHostMsg_GetPluginInfo_Status::kPlayImportantContent;