Plugin Power Saver: Make PPS work well with prerendered pages.

content/renderer/pepper/plugin_instance_throttler_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/pepper/plugin_instance_throttler_impl.h"
 
 #include "base/metrics/histogram.h"
 #include "base/time/time.h"
 #include "content/public/common/content_constants.h"
 #include "content/public/renderer/render_thread.h"
@@ skipping 84 matching lines @@
 void PluginInstanceThrottlerImpl::MarkPluginEssential(
     PowerSaverUnthrottleMethod method) {
   if (state_ == THROTTLER_STATE_MARKED_ESSENTIAL)
     return;
 
   bool was_throttled = IsThrottled();
   state_ = THROTTLER_STATE_MARKED_ESSENTIAL;
   RecordUnthrottleMethodMetric(method);
 
   if (was_throttled)
-    FOR_EACH_OBSERVER(Observer, observer_list_, OnThrottleStateChange());
+    BroadcastThrottleStateChange();
 
   // Notify the Power Saver test plugin of a peripheral status change.
   if (web_plugin_ && web_plugin_->instance() &&
       plugin_module_name_ == ppapi::kPowerSaverTestPluginName) {
     web_plugin_->instance()->HandleMessage(ppapi::ScopedPPVar(
         ppapi::ScopedPPVar::PassRef(),
         ppapi::StringVar::StringToPPVar("peripheralStatusChange")));
   }
 }
 
@@ skipping 106 matching lines @@
 
   if (!last_received_frame_.empty()) {
     FOR_EACH_OBSERVER(Observer, observer_list_,
                       OnKeyframeExtracted(&last_received_frame_));
 
     // Release our reference to the underlying pixel data.
     last_received_frame_.reset();
   }
 
   state_ = THROTTLER_STATE_PLUGIN_THROTTLED;
+  BroadcastThrottleStateChange();
+}
+
+void PluginInstanceThrottlerImpl::BroadcastThrottleStateChange() {
   FOR_EACH_OBSERVER(Observer, observer_list_, OnThrottleStateChange());
+
+  // Notify the Power Saver test plugin of a throttle status change.
+  if (web_plugin_ && web_plugin_->instance() &&
+      plugin_module_name_ == ppapi::kPowerSaverTestPluginName) {
+    web_plugin_->instance()->HandleMessage(ppapi::ScopedPPVar(
+        ppapi::ScopedPPVar::PassRef(),
+        ppapi::StringVar::StringToPPVar("throttleStatusChange")));
+  }

[raymes, 2015/04/29 00:12:34]

It feels a little weird to have this test code in here. Perhaps consider
delegating it out if there is a way to do that which isn't too complicated.

[tommycli, 2015/04/29 20:25:47]

Done.

 }
 
 }  // namespace content