chrome/test/data/prerender/prerender_plugin_power_saver.html - Issue 1114623002: Plugin Power Saver: Make PPS work well with prerendered pages.

Side by Side Diff: chrome/test/data/prerender/prerender_plugin_power_saver.html

Issue 1114623002: Plugin Power Saver: Make PPS work well with prerendered pages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/test/data/prerender/prerender_plugin_delay_load.html ('K') | « chrome/test/data/prerender/prerender_plugin_never_load.html ('k') | components/plugins/renderer/loadable_plugin_placeholder.h » ('j') | content/renderer/pepper/plugin_instance_throttler_impl.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <!--

	3 This test checks the interaction between prerender and the Plugin Power Saver

	4 feature. It expects:

	5 - The plugin is not loaded during prerender.

	6 - It is loaded (briefly) during the preroll of the plugin.

	7 - It is replaced by the placeholder after the preroll is over.

	8

	9 This test relies on the Pepper plugin (but not the placeholder) implementing

	10 the postMessage() function on the plugin object.

	11 -->

	12 <head>

	13 <title>Prerender Plugin Delay Loading</title>

	14

	15 <script>

	16 // Make sure plugin was not loaded while prerendering.

	17 function DidPrerenderPass() {

	18 // \|plugin\| should be the blocked plugin placeholder, rather than the

	19 // test plugin.

	20 var plugin = window.document['plugin'];
	Bernhard Bauer 2015/04/29 09:42:36 Use getElementById? Named properties on the docume Use getElementById? Named properties on the document seems very... 90s ;-) tommycli 2015/04/29 20:25:47 Done. Show quoted text On 2015/04/29 09:42:36, Bernhard Bauer wrote: > Use getElementById? Named properties on the document seems very... 90s ;-) Done.
	21 return plugin.postMessage == undefined;
	Bernhard Bauer 2015/04/29 09:42:36 Use `===` maybe? `==` can have some weird effects Use `===` maybe? `==` can have some weird effects because of its argument coercing (for example, `null == undefined` is true). Alternatively, if you are okay with returning true for the null case (which shouldn't happen anyway), you could just do `!plugin.postMessage`. That would at least make your intent clearer. tommycli 2015/04/29 20:25:47 Done. Show quoted text On 2015/04/29 09:42:36, Bernhard Bauer wrote: > Use `===` maybe? `==` can have some weird effects because of its argument > coercing (for example, `null == undefined` is true). > > Alternatively, if you are okay with returning true for the null case (which > shouldn't happen anyway), you could just do `!plugin.postMessage`. That would at > least make your intent clearer. Done.
	22 }

	23

	24 // Make sure the plugin briefly exists, then is replaced with a placeholder.

	25 function AwaitPluginPrerollAndPlaceholder() {
	tommycli 2015/04/28 18:43:16 This is the new test 'repros' the old problem and This is the new test 'repros' the old problem and now works.
	26 var plugin = window.document['plugin'];

	27 function handleEvent(event) {

	28 // We should eventually get a message indicating that the plugin has been

	29 // throttled and replaced with a static placeholder.

	30 if (event.data.isThrottled) {

	31 plugin.removeEventListener('message', handleEvent);

	32 window.domAutomationController.send(plugin.postMessage == undefined);

	33 }

	34 }

	35

	36 // The plugin should (briefly) exist for the preroll phase.

	37 if (plugin.postMessage == undefined) {

	38 window.domAutomationController.send(false);

	39 }

	40

	41 plugin.addEventListener('message', handleEvent);

	42 plugin.postMessage('getPowerSaverStatus');

	43 }

	44 </script>

	45

	46 </head>

	47 <body>

	48

	49 <object name="plugin" type="application/x-ppapi-tests" height='100' width='100'>

	50 </object>

	51

	52 </body>

	53 </html>

OLD	NEW