Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11146008: remove VideoDeviceError and AudioDeviceError for media stream. (Closed)

Created:
8 years, 2 months ago by wjia(left Chromium)
Modified:
8 years, 2 months ago
Reviewers:
perkj_chrome, piman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, Satish, jam, feature-media-reviews_chromium.org
Visibility:
Public.

Description

remove VideoDeviceError and AudioDeviceError for media stream. Per discussion with perkj@, after media stream is generated, all error messages would be sent to client, instead of media stream. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=162235

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -189 lines) Patch
M content/browser/renderer_host/media/media_stream_dispatcher_host.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host.cc View 1 chunk +0 lines, -28 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc View 3 chunks +0 lines, -22 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_requester.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_controller.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/speech/speech_recognition_manager_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/common/media/media_stream_messages.h View 1 chunk +0 lines, -10 lines 0 comments Download
M content/renderer/media/media_stream_dispatcher.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/media/media_stream_dispatcher.cc View 2 chunks +0 lines, -36 lines 0 comments Download
M content/renderer/media/media_stream_dispatcher_eventhandler.h View 1 chunk +0 lines, -10 lines 0 comments Download
M content/renderer/media/media_stream_dispatcher_unittest.cc View 4 chunks +1 line, -28 lines 0 comments Download
M content/renderer/media/media_stream_impl.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/renderer/media/media_stream_impl.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M content/renderer/pepper/pepper_device_enumeration_event_handler.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/pepper/pepper_device_enumeration_event_handler.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
wjia(left Chromium)
8 years, 2 months ago (2012-10-14 17:39:43 UTC) #1
perkj_chrome
On 2012/10/14 17:39:43, wjia wrote: lgtm
8 years, 2 months ago (2012-10-15 11:01:07 UTC) #2
wjia(left Chromium)
+piman@ for owner's stamp.
8 years, 2 months ago (2012-10-15 16:54:58 UTC) #3
piman
8 years, 2 months ago (2012-10-16 02:45:32 UTC) #4 
lgtm

Powered by Google App Engine
This is Rietveld 408576698