build/protoc_java.sh - Issue 11146005: Add support for generating jars from protos and add cacheinvalidation_java.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/protoc_java.sh

Issue 11146005: Add support for generating jars from protos and add cacheinvalidation_java. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove unused target Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 #!/bin/bash	1 #!/bin/bash

2

3 # Copyright (c) 2012 The Chromium Authors. All rights reserved.	2 # Copyright (c) 2012 The Chromium Authors. All rights reserved.

4 # Use of this source code is governed by a BSD-style license that can be	3 # Use of this source code is governed by a BSD-style license that can be

5 # found in the LICENSE file.	4 # found in the LICENSE file.

6	5 if [ -d "$3" ]; then

7 # Test whether or not the current desktop is virtual Me2Me.	6 rm -rf $3

8	7 fi

9 [ -n "$CHROME_REMOTE_DESKTOP_SESSION" ]	8 if [ -e "$4" ]; then

	9 rm -f $4

	10 fi

	11 mkdir -p $3

	12 $1 --proto_path $2 --java_out $3 "${@:5}"

	13 touch $4
	Ryan Sleevi 2012/10/30 00:50:43 Seems like you will want to get someone with bash Seems like you will want to get someone with bash readability to look at this, but I'm instantly nervous about the lack of quoting around file system paths here, especially if the originally arrived quoted (eg: protoc_java.sh protoc dummy "src /"). I realize the quotes for lines 5/8 probably mitigate this, but it is enough to raise an eyebrow at (and wonder about how it would affect line 12, since $2 isn't quoted) nyquist 2012/10/31 17:49:33 Changed to use Python. Show quoted text On 2012/10/30 00:50:43, Ryan Sleevi wrote: > Seems like you will want to get someone with bash readability to look at this, > but I'm instantly nervous about the lack of quoting around file system paths > here, especially if the originally arrived quoted (eg: protoc_java.sh protoc > dummy "src /"). I realize the quotes for lines 5/8 probably mitigate this, but > it is enough to raise an eyebrow at (and wonder about how it would affect line > 12, since $2 isn't quoted) Changed to use Python.
OLD	NEW

« build/protoc_java.gypi ('K') | « build/protoc_java.gypi ('k') | third_party/cacheinvalidation/cacheinvalidation.gyp » ('j') | no next file with comments »