Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: chrome/browser/extensions/installed_loader.cc

Issue 1114583002: [Extensions] Fix InstalledLoader histograms to ignore component extenisons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/installed_loader.cc
diff --git a/chrome/browser/extensions/installed_loader.cc b/chrome/browser/extensions/installed_loader.cc
index e34f73282f4f63d7faad59dc56ff94145365be26..adebc1e246ed3ec3834ec35ccbe6995b9e50b88b 100644
--- a/chrome/browser/extensions/installed_loader.cc
+++ b/chrome/browser/extensions/installed_loader.cc
@@ -389,7 +389,7 @@ void InstalledLoader::RecordExtensionsMetrics() {
// From now on, don't count component extensions, since they are only
// extensions as an implementation detail. Continue to count unpacked
// extensions for a few metrics.
- if (location == Manifest::COMPONENT)
+ if (Manifest::IsComponentLocation(location))
continue;
// Histogram for non-webstore extensions overriding new tab page should
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698