src/ia32/lithium-codegen-ia32.cc - Issue 1114563003: Optimize the typeof operator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/lithium-codegen-ia32.cc

Issue 1114563003: Optimize the typeof operator. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix mips/mips64 errors. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/lithium-codegen-ia32.cc

diff --git a/src/ia32/lithium-codegen-ia32.cc b/src/ia32/lithium-codegen-ia32.cc

index 5af19d01ef4d5592c2498c92001d805b1e68ac59..f27631ca908b749fa9ae9dee2945f152536c5ff1 100644

--- a/src/ia32/lithium-codegen-ia32.cc

+++ b/src/ia32/lithium-codegen-ia32.cc

@@ -5374,9 +5374,16 @@ void LCodeGen::DoFunctionLiteral(LFunctionLiteral* instr) {

void LCodeGen::DoTypeof(LTypeof* instr) {

DCHECK(ToRegister(instr->context()).is(esi));

- LOperand* input = instr->value();

- EmitPushTaggedOperand(input);

- CallRuntime(Runtime::kTypeof, 1, instr);

+ DCHECK(ToRegister(instr->value()).is(ebx));

+ Label end, do_call;

+ Register value_register = ToRegister(instr->value());

+ __ JumpIfNotSmi(value_register, &do_call);

+ __ mov(eax, Immediate(isolate()->factory()->number_string()));

+ __ jmp(&end);

+ __ bind(&do_call);

+ TypeofStub stub(isolate());

+ CallCode(stub.GetCode(), RelocInfo::CODE_TARGET, instr);

+ __ bind(&end);

}