Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Side by Side Diff: src/arm64/lithium-arm64.cc

Issue 1114563003: Optimize the typeof operator. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: REBASE. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arm64/interface-descriptors-arm64.cc ('k') | src/arm64/lithium-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <sstream> 5 #include <sstream>
6 6
7 #include "src/v8.h" 7 #include "src/v8.h"
8 8
9 #include "src/arm64/lithium-codegen-arm64.h" 9 #include "src/arm64/lithium-codegen-arm64.h"
10 #include "src/hydrogen-osr.h" 10 #include "src/hydrogen-osr.h"
(...skipping 2551 matching lines...) Expand 10 before | Expand all | Expand 10 after
2562 LOperand* temp1 = TempRegister(); 2562 LOperand* temp1 = TempRegister();
2563 LOperand* temp2 = TempRegister(); 2563 LOperand* temp2 = TempRegister();
2564 LTrapAllocationMemento* result = 2564 LTrapAllocationMemento* result =
2565 new(zone()) LTrapAllocationMemento(object, temp1, temp2); 2565 new(zone()) LTrapAllocationMemento(object, temp1, temp2);
2566 return AssignEnvironment(result); 2566 return AssignEnvironment(result);
2567 } 2567 }
2568 2568
2569 2569
2570 LInstruction* LChunkBuilder::DoTypeof(HTypeof* instr) { 2570 LInstruction* LChunkBuilder::DoTypeof(HTypeof* instr) {
2571 LOperand* context = UseFixed(instr->context(), cp); 2571 LOperand* context = UseFixed(instr->context(), cp);
2572 // TODO(jbramley): In ARM, this uses UseFixed to force the input to x0. 2572 LOperand* value = UseFixed(instr->value(), x3);
2573 // However, LCodeGen::DoTypeof just pushes it to the stack (for CallRuntime) 2573 LTypeof* result = new (zone()) LTypeof(context, value);
2574 // anyway, so the input doesn't have to be in x0. We might be able to improve
2575 // the ARM back-end a little by relaxing this restriction.
2576 LTypeof* result =
2577 new(zone()) LTypeof(context, UseRegisterAtStart(instr->value()));
2578 return MarkAsCall(DefineFixed(result, x0), instr); 2574 return MarkAsCall(DefineFixed(result, x0), instr);
2579 } 2575 }
2580 2576
2581 2577
2582 LInstruction* LChunkBuilder::DoTypeofIsAndBranch(HTypeofIsAndBranch* instr) { 2578 LInstruction* LChunkBuilder::DoTypeofIsAndBranch(HTypeofIsAndBranch* instr) {
2583 // We only need temp registers in some cases, but we can't dereference the 2579 // We only need temp registers in some cases, but we can't dereference the
2584 // instr->type_literal() handle to test that here. 2580 // instr->type_literal() handle to test that here.
2585 LOperand* temp1 = TempRegister(); 2581 LOperand* temp1 = TempRegister();
2586 LOperand* temp2 = TempRegister(); 2582 LOperand* temp2 = TempRegister();
2587 2583
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
2761 HAllocateBlockContext* instr) { 2757 HAllocateBlockContext* instr) {
2762 LOperand* context = UseFixed(instr->context(), cp); 2758 LOperand* context = UseFixed(instr->context(), cp);
2763 LOperand* function = UseRegisterAtStart(instr->function()); 2759 LOperand* function = UseRegisterAtStart(instr->function());
2764 LAllocateBlockContext* result = 2760 LAllocateBlockContext* result =
2765 new(zone()) LAllocateBlockContext(context, function); 2761 new(zone()) LAllocateBlockContext(context, function);
2766 return MarkAsCall(DefineFixed(result, cp), instr); 2762 return MarkAsCall(DefineFixed(result, cp), instr);
2767 } 2763 }
2768 2764
2769 2765
2770 } } // namespace v8::internal 2766 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm64/interface-descriptors-arm64.cc ('k') | src/arm64/lithium-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698