Optimize the typeof operator.

src/code-stubs-hydrogen.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/bailout-reason.h"
 #include "src/code-stubs.h"
 #include "src/field-index.h"
 #include "src/hydrogen.h"
@@ skipping 281 matching lines @@
   HValue* number = GetParameter(NumberToStringStub::kNumber);
   return BuildNumberToString(number, Type::Number(zone()));
 }
 
 
 Handle<Code> NumberToStringStub::GenerateCode() {
   return DoGenerateCode(this);
 }
 
 
+// Returns the type string of a value; see ECMA-262, 11.4.3 (p 47).
+// Possible optimizations: put the type string into the oddballs.
+template <>
+HValue* CodeStubGraphBuilder<TypeofStub>::BuildCodeStub() {
+  Factory* factory = isolate()->factory();
+  HConstant* number_string = Add<HConstant>(factory->number_string());
+  HValue* object = GetParameter(TypeofStub::kObject);
+
+  IfBuilder is_smi(this);
+  HValue* smi_check = is_smi.If<HIsSmiAndBranch>(object);
+  is_smi.Then();
+  { Push(number_string); }
+  is_smi.Else();
+  {
+    HValue* map = AddLoadMap(object, smi_check);
+    HConstant* number_map =
+        Add<HConstant>(isolate()->factory()->heap_number_map());
+    IfBuilder is_number(this);
+    is_number.If<HCompareObjectEqAndBranch>(map, number_map);

[Toon Verwaest, 2015/04/30 14:01:09]

Any reason why you didn't use HCompareMap(object,
isolate()->factory()->heap_number_map())?

[mvstanton, 2015/05/06 09:55:27]

Done.

+    is_number.Then();
+    { Push(number_string); }
+    is_number.Else();
+    {
+      // Is it an undetectable object?

[Toon Verwaest, 2015/04/30 14:01:08]

This is only possible for JSObjects, so should probably be checked after all the
other checks?

[mvstanton, 2015/05/06 09:55:27]

Done.

+      HConstant* undefined_string = Add<HConstant>(factory->undefined_string());
+      HValue* bit_field =
+          Add<HLoadNamedField>(map, nullptr, HObjectAccess::ForMapBitField());
+      HValue* is_undetectable_mask = Add<HConstant>(1 << Map::kIsUndetectable);
+      HValue* is_undetectable_test = AddUncasted<HBitwise>(
+          Token::BIT_AND, bit_field, is_undetectable_mask);
+      IfBuilder is_undetectable(this);
+      is_undetectable.If<HCompareNumericAndBranch>(
+          is_undetectable_test, graph()->GetConstant0(), Token::NE);

[Toon Verwaest, 2015/04/30 14:01:08]

HIsUndetectableAndBranch

[mvstanton, 2015/05/06 09:55:27]

Done.

+      is_undetectable.Then();
+      {
+        // typeof an undetectable object is 'undefined'.
+        Push(undefined_string);
+      }
+      is_undetectable.Else();
+      {
+        HValue* instance_type = Add<HLoadNamedField>(
+            map, nullptr, HObjectAccess::ForMapInstanceType());
+        IfBuilder is_string(this);
+        is_string.If<HCompareNumericAndBranch>(
+            instance_type, Add<HConstant>(FIRST_NONSTRING_TYPE), Token::LT);

[Toon Verwaest, 2015/04/30 14:01:08]

<HCheckInstanceType>(string, HCheckInstanceType::IS_STRING)

[mvstanton, 2015/05/06 09:55:27]

I didn't do this because there are so many cases I want to check with the
instance type, string being just one of them.

+        is_string.Then();
+        { Push(Add<HConstant>(factory->string_string())); }
+        is_string.Else();
+
+        HConstant* object_string = Add<HConstant>(factory->object_string());
+        IfBuilder is_oddball(this);
+        is_oddball.If<HCompareNumericAndBranch>(
+            instance_type, Add<HConstant>(ODDBALL_TYPE), Token::EQ);
+        is_oddball.Then();
+        {
+          IfBuilder is_true_or_false(this);
+          is_true_or_false.If<HCompareObjectEqAndBranch>(
+              object, graph()->GetConstantTrue());
+          is_true_or_false.OrIf<HCompareObjectEqAndBranch>(
+              object, graph()->GetConstantFalse());
+          is_true_or_false.Then();
+          { Push(Add<HConstant>(factory->boolean_string())); }
+          is_true_or_false.Else();
+          {
+            IfBuilder is_null(this);
+            is_null.If<HCompareObjectEqAndBranch>(object,
+                                                  graph()->GetConstantNull());
+            is_null.Then();
+            { Push(object_string); }
+            is_null.Else();
+            { Push(undefined_string); }
+          }
+          is_true_or_false.End();
+        }
+        is_oddball.Else();
+        {
+          IfBuilder is_symbol(this);
+          is_symbol.If<HCompareNumericAndBranch>(
+              instance_type, Add<HConstant>(SYMBOL_TYPE), Token::EQ);
+          is_symbol.Then();
+          { Push(Add<HConstant>(factory->symbol_string())); }
+          is_symbol.Else();
+          {
+            IfBuilder is_function(this);
+            HConstant* js_function = Add<HConstant>(JS_FUNCTION_TYPE);
+            HConstant* js_function_proxy =
+                Add<HConstant>(JS_FUNCTION_PROXY_TYPE);
+            is_function.If<HCompareNumericAndBranch>(instance_type, js_function,
+                                                     Token::EQ);
+            is_function.OrIf<HCompareNumericAndBranch>(
+                instance_type, js_function_proxy, Token::EQ);
+            is_function.Then();
+            { Push(Add<HConstant>(factory->function_string())); }
+            is_function.Else();
+            {
+              // For any kind of object not handled above, the spec rule for
+              // host objects gives that it is okay to return "object".
+              Push(object_string);
+            }
+            is_function.End();
+          }
+          is_symbol.End();
+        }
+        is_oddball.End();
+        is_string.End();
+      }
+      is_undetectable.End();
+    }
+    is_number.End();
+  }
+  is_smi.End();
+
+  return environment()->Pop();
+}
+
+
+Handle<Code> TypeofStub::GenerateCode() { return DoGenerateCode(this); }
+
+
 template <>
 HValue* CodeStubGraphBuilder<FastCloneShallowArrayStub>::BuildCodeStub() {
   Factory* factory = isolate()->factory();
   HValue* undefined = graph()->GetConstantUndefined();
   AllocationSiteMode alloc_site_mode = casted_stub()->allocation_site_mode();
 
   // This stub is very performance sensitive, the generated code must be tuned
   // so that it doesn't build and eager frame.
   info()->MarkMustNotHaveEagerFrame();
 
@@ skipping 1737 matching lines @@
   // need.
   info()->MarkMustNotHaveEagerFrame();
 
   // Probe the stub cache.
   Add<HTailCallThroughMegamorphicCache>(receiver, name);
 
   // We never continue.
   return graph()->GetConstant0();
 }
 } }  // namespace v8::internal