Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(989)

Side by Side Diff: src/arm64/lithium-arm64.cc

Issue 1114563003: Optimize the typeof operator. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Ports. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <sstream> 5 #include <sstream>
6 6
7 #include "src/v8.h" 7 #include "src/v8.h"
8 8
9 #include "src/arm64/lithium-codegen-arm64.h" 9 #include "src/arm64/lithium-codegen-arm64.h"
10 #include "src/hydrogen-osr.h" 10 #include "src/hydrogen-osr.h"
(...skipping 2542 matching lines...) Expand 10 before | Expand all | Expand 10 after
2553 LOperand* temp1 = TempRegister(); 2553 LOperand* temp1 = TempRegister();
2554 LOperand* temp2 = TempRegister(); 2554 LOperand* temp2 = TempRegister();
2555 LTrapAllocationMemento* result = 2555 LTrapAllocationMemento* result =
2556 new(zone()) LTrapAllocationMemento(object, temp1, temp2); 2556 new(zone()) LTrapAllocationMemento(object, temp1, temp2);
2557 return AssignEnvironment(result); 2557 return AssignEnvironment(result);
2558 } 2558 }
2559 2559
2560 2560
2561 LInstruction* LChunkBuilder::DoTypeof(HTypeof* instr) { 2561 LInstruction* LChunkBuilder::DoTypeof(HTypeof* instr) {
2562 LOperand* context = UseFixed(instr->context(), cp); 2562 LOperand* context = UseFixed(instr->context(), cp);
2563 // TODO(jbramley): In ARM, this uses UseFixed to force the input to x0. 2563 LOperand* value = UseFixed(instr->value(), x3);
2564 // However, LCodeGen::DoTypeof just pushes it to the stack (for CallRuntime) 2564 LTypeof* result = new (zone()) LTypeof(context, value);
2565 // anyway, so the input doesn't have to be in x0. We might be able to improve
2566 // the ARM back-end a little by relaxing this restriction.
2567 LTypeof* result =
2568 new(zone()) LTypeof(context, UseRegisterAtStart(instr->value()));
2569 return MarkAsCall(DefineFixed(result, x0), instr); 2565 return MarkAsCall(DefineFixed(result, x0), instr);
2570 } 2566 }
2571 2567
2572 2568
2573 LInstruction* LChunkBuilder::DoTypeofIsAndBranch(HTypeofIsAndBranch* instr) { 2569 LInstruction* LChunkBuilder::DoTypeofIsAndBranch(HTypeofIsAndBranch* instr) {
2574 // We only need temp registers in some cases, but we can't dereference the 2570 // We only need temp registers in some cases, but we can't dereference the
2575 // instr->type_literal() handle to test that here. 2571 // instr->type_literal() handle to test that here.
2576 LOperand* temp1 = TempRegister(); 2572 LOperand* temp1 = TempRegister();
2577 LOperand* temp2 = TempRegister(); 2573 LOperand* temp2 = TempRegister();
2578 2574
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
2752 HAllocateBlockContext* instr) { 2748 HAllocateBlockContext* instr) {
2753 LOperand* context = UseFixed(instr->context(), cp); 2749 LOperand* context = UseFixed(instr->context(), cp);
2754 LOperand* function = UseRegisterAtStart(instr->function()); 2750 LOperand* function = UseRegisterAtStart(instr->function());
2755 LAllocateBlockContext* result = 2751 LAllocateBlockContext* result =
2756 new(zone()) LAllocateBlockContext(context, function); 2752 new(zone()) LAllocateBlockContext(context, function);
2757 return MarkAsCall(DefineFixed(result, cp), instr); 2753 return MarkAsCall(DefineFixed(result, cp), instr);
2758 } 2754 }
2759 2755
2760 2756
2761 } } // namespace v8::internal 2757 } } // namespace v8::internal
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698