Remove the weak list of array buffers

Remove the weak list of array buffers

Instead, collect live array buffers during marking and free pointers we
no longer found.

BUG=v8:3996
R=hpayer@chromium.org
LOG=n

Committed: https://crrev.com/2d39709cf5ee17637f6f2d75380a9e61ae0b342b
Cr-Commit-Position: refs/heads/master@{#28132}

[jochen (gone - plz use gerrit), 2015-04-28 14:57:15]

jochen@chromium.org changed reviewers:
+ dslomov@chromium.org

[jochen (gone - plz use gerrit), 2015-04-28 14:57:15]

+dslomov

[jochen (gone - plz use gerrit), 2015-04-28 19:46:44]

note to self...

https://codereview.chromium.org/1114563002/diff/60001/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/1114563002/diff/60001/src/heap/heap.cc#newcod...
src/heap/heap.cc:1326: not_yet_discovered_array_buffers_ = live_array_buffers_;
so the bug is here... Heap::MarkCompactPrologue is not necessarily invoked when
marking starts, e.g. if we're incrementally marking

[jochen (gone - plz use gerrit), 2015-04-29 07:27:55]

ptal

[Hannes Payer (out of office), 2015-04-29 11:48:21]

LGTM, just nits

https://codereview.chromium.org/1114563002/diff/120001/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/1114563002/diff/120001/src/heap/heap.cc#newco...
src/heap/heap.cc:1296: ReapDeadArrayBuffers();
Please move this call to sweeping, since it frees up memory and therefore
logically belongs there.

https://codereview.chromium.org/1114563002/diff/120001/src/heap/heap.cc#newco...
src/heap/heap.cc:1725: void Heap::RegisterLiveArrayBuffer(void* data, size_t
length) {
What about calling this method RegisterNewArrayBuffer?

https://codereview.chromium.org/1114563002/diff/120001/src/heap/heap.cc#newco...
src/heap/heap.cc:1739: void Heap::AddDiscoveredArrayBuffer(void* data) {
And since this method is not adding an array buffer, what about calling it
RegisterLiveArrayBuffer?

https://codereview.chromium.org/1114563002/diff/120001/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/1114563002/diff/120001/src/heap/heap.h#newcod...
src/heap/heap.h:1540: void ReapDeadArrayBuffers();
Can we call it FreeDeadArrayBuffers?

[jochen (gone - plz use gerrit), 2015-04-29 12:36:27]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2015-04-29 12:36:27]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/1114563002/#ps140001
(title: "updates")

[commit-bot: I haz the power, 2015-04-29 12:36:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1114563002/140001

[jochen (gone - plz use gerrit), 2015-04-29 12:36:35]

all done

[commit-bot: I haz the power, 2015-04-29 13:04:47]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2015-04-29 13:05:06]

Patchset 8 (id:??) landed as
https://crrev.com/2d39709cf5ee17637f6f2d75380a9e61ae0b342b
Cr-Commit-Position: refs/heads/master@{#28132}

[Michael Achenbach, 2015-04-30 08:38:02]

A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/1115043005/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Crashes in layout tests:
https://chromegw.corp.google.com/i/client.v8/builders/V8-Blink%20Linux%2064%2....