Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1114543004: Avoid creating ancestor clipping layers for scroll children (Closed)

Created:
5 years, 7 months ago by Ian Vollick
Modified:
5 years, 7 months ago
Reviewers:
hartmanng
CC:
blink-reviews, blink-reviews-rendering, Dominik Röttsches, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Avoid creating ancestor clipping layers for scroll children We had logic for detecting when an ancestor clipping layer was due to a scroll parent already, but it was busted. This CL simply checks if the scroll parent is the clipping container which is both easier to understand and actually correct. BUG=450756 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194671

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Adding a layout test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -14 lines) Patch
A LayoutTests/compositing/overflow/avoid-ancestor-clip-for-scroll-children.html View 1 2 1 chunk +72 lines, -0 lines 0 comments Download
A LayoutTests/compositing/overflow/avoid-ancestor-clip-for-scroll-children-expected.txt View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp View 1 5 chunks +8 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Ian Vollick
5 years, 7 months ago (2015-04-29 16:53:35 UTC) #3
hartmanng
lgtm
5 years, 7 months ago (2015-04-29 18:32:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1114543004/40001
5 years, 7 months ago (2015-04-29 18:35:40 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 20:54:56 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194671

Powered by Google App Engine
This is Rietveld 408576698