Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(883)

Unified Diff: chrome/browser/chromeos/login/screens/user_selection_screen.cc

Issue 1114543002: UMA to track the reason for re-auth (draft). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Code review fixes. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/screens/user_selection_screen.cc
diff --git a/chrome/browser/chromeos/login/screens/user_selection_screen.cc b/chrome/browser/chromeos/login/screens/user_selection_screen.cc
index 9bcb4048b14c8dcf8444ae2a47e7ea4cc4fb310b..4b633308ce49b9e76422b87a08c32181cdc03324 100644
--- a/chrome/browser/chromeos/login/screens/user_selection_screen.cc
+++ b/chrome/browser/chromeos/login/screens/user_selection_screen.cc
@@ -11,6 +11,7 @@
#include "chrome/browser/browser_process.h"
#include "chrome/browser/browser_process_platform_part.h"
#include "chrome/browser/chromeos/login/lock/screen_locker.h"
+#include "chrome/browser/chromeos/login/reauth_stats.h"
#include "chrome/browser/chromeos/login/ui/login_display_host_impl.h"
#include "chrome/browser/chromeos/login/ui/views/user_board_view.h"
#include "chrome/browser/chromeos/login/users/chrome_user_manager.h"
@@ -236,6 +237,11 @@ bool UserSelectionScreen::ShouldForceOnlineSignIn(
if (is_public_session)
return false;
+ // At this point the reason for invalid token should be already set. If not,
+ // this might be a leftover from an old version.
+ if (token_status == user_manager::User::OAUTH2_TOKEN_STATUS_INVALID)
+ RecordReauthReason(user->email(), ReauthReason::OTHER);
+
return user->force_online_signin() ||
(token_status == user_manager::User::OAUTH2_TOKEN_STATUS_INVALID) ||
(token_status == user_manager::User::OAUTH_TOKEN_STATUS_UNKNOWN);
@@ -426,6 +432,7 @@ void UserSelectionScreen::OnUserStatusChecked(
const user_manager::UserID& user_id,
TokenHandleUtil::TokenHandleStatus status) {
if (status == TokenHandleUtil::INVALID) {
+ RecordReauthReason(user_id, ReauthReason::INVALID_TOKEN_HANDLE);
user_manager::UserManager::Get()->SaveUserOAuthStatus(
user_id, user_manager::User::OAUTH2_TOKEN_STATUS_INVALID);
token_handle_util_->DeleteToken(user_id);

Powered by Google App Engine
This is Rietveld 408576698