Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: chrome/browser/chromeos/login/existing_user_controller.cc

Issue 1114543002: UMA to track the reason for re-auth (draft). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Code review fixes. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/reauth_stats.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/existing_user_controller.cc
diff --git a/chrome/browser/chromeos/login/existing_user_controller.cc b/chrome/browser/chromeos/login/existing_user_controller.cc
index 4cb375342cb0207393f597bf3c97b342113ad174..bcec5fdc4a5ce630c285d113379f5385166e4fc8 100644
--- a/chrome/browser/chromeos/login/existing_user_controller.cc
+++ b/chrome/browser/chromeos/login/existing_user_controller.cc
@@ -28,6 +28,7 @@
#include "chrome/browser/chromeos/login/easy_unlock/bootstrap_user_context_initializer.h"
#include "chrome/browser/chromeos/login/easy_unlock/bootstrap_user_flow.h"
#include "chrome/browser/chromeos/login/helper.h"
+#include "chrome/browser/chromeos/login/reauth_stats.h"
#include "chrome/browser/chromeos/login/session/user_session_manager.h"
#include "chrome/browser/chromeos/login/signin/oauth2_token_initializer.h"
#include "chrome/browser/chromeos/login/signin_specifics.h"
@@ -572,6 +573,14 @@ void ExistingUserController::OnAuthFailure(const AuthFailure& failure) {
// Clear the recorded displayed email so it won't affect any future attempts.
display_email_.clear();
+
+ // TODO(ginkage): Fix this case once crbug.com/469990 is ready.
+ /*
+ if (failure.reason() == AuthFailure::COULD_NOT_MOUNT_CRYPTOHOME) {
+ RecordReauthReason(last_login_attempt_username_,
+ ReauthReason::MISSING_CRYPTOHOME);
+ }
+ */
}
void ExistingUserController::OnAuthSuccess(const UserContext& user_context) {
@@ -976,6 +985,7 @@ void ExistingUserController::ShowGaiaPasswordChanged(
// changed.
user_manager::UserManager::Get()->SaveUserOAuthStatus(
username, user_manager::User::OAUTH2_TOKEN_STATUS_INVALID);
+ RecordReauthReason(username, ReauthReason::OTHER);
login_display_->SetUIEnabled(true);
login_display_->ShowGaiaPasswordChanged(username);
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/reauth_stats.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698