Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 1114503004: Add .gitignore and codereview.settings (Closed)

Created:
5 years, 7 months ago by Sam Clegg
Modified:
5 years, 7 months ago
Reviewers:
bradnelson, bradn
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/third_party.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Add .gitignore and codereview.settings Now that this repo is hosted natively in git these are useful/needed. R=bradnelson@google.com Committed: https://chromium.googlesource.com/native_client/src/third_party/+/326ae729e5c51ce70b4df5c50e12bed91fe866b5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
A .gitignore View 1 chunk +11 lines, -0 lines 0 comments Download
A codereview.settings View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Sam Clegg
Decided to split this CL
5 years, 7 months ago (2015-04-28 21:07:52 UTC) #2
bradn
lgtm
5 years, 7 months ago (2015-04-28 21:09:22 UTC) #4
Sam Clegg
5 years, 7 months ago (2015-04-28 21:19:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
326ae729e5c51ce70b4df5c50e12bed91fe866b5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698