Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2471)

Unified Diff: editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/configs/DartServerLaunchConfigurationDelegate.java

Issue 11145023: Fix bug 5883: (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/dbg_message.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/configs/DartServerLaunchConfigurationDelegate.java
===================================================================
--- editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/configs/DartServerLaunchConfigurationDelegate.java (revision 13660)
+++ editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/configs/DartServerLaunchConfigurationDelegate.java (working copy)
@@ -17,6 +17,7 @@
import com.google.dart.tools.core.model.DartSdkManager;
import com.google.dart.tools.debug.core.DartDebugCorePlugin;
import com.google.dart.tools.debug.core.DartLaunchConfigWrapper;
+import com.google.dart.tools.debug.core.server.ServerDebugTarget;
import com.google.dart.tools.debug.core.util.NetUtils;
import org.eclipse.core.resources.IResource;
@@ -114,11 +115,9 @@
commandsList.add(vmExecPath);
commandsList.addAll(Arrays.asList(launchConfig.getVmArgumentsAsArray()));
- // BUG(5883) Debugging of standalone programs is disabled
- // because it sometimes leads to program crashes.
-// if (enableDebugging && !DartCore.isWindows()) {
-// commandsList.add("--debug:" + connectionPort);
-// }
+ if (enableDebugging && !DartCore.isWindows()) {
+ commandsList.add("--debug:" + connectionPort);
+ }
String packageRoot = DartCore.getPlugin().getPackageRootPref();
if (packageRoot != null) {
@@ -177,23 +176,21 @@
eclipseProcess.setAttribute(IProcess.ATTR_CMDLINE, generateCommandLine(commands));
- // BUG(5883) Debugging of standalone programs is disabled
- // because it sometimes leads to program crashes.
-// if (enableDebugging && !DartCore.isWindows()) {
-// ServerDebugTarget debugTarget = new ServerDebugTarget(launch, eclipseProcess, connectionPort);
-//
-// try {
-// debugTarget.connect();
-//
-// launch.addDebugTarget(debugTarget);
-// } catch (DebugException ex) {
-// // We don't throw an exception if the process died before we could connect.
-// if (!isProcessDead(runtimeProcess)) {
-// throw ex;
-// }
-// }
-// }
+ if (enableDebugging && !DartCore.isWindows()) {
+ ServerDebugTarget debugTarget = new ServerDebugTarget(launch, eclipseProcess, connectionPort);
+ try {
+ debugTarget.connect();
+
+ launch.addDebugTarget(debugTarget);
+ } catch (DebugException ex) {
+ // We don't throw an exception if the process died before we could connect.
+ if (!isProcessDead(runtimeProcess)) {
+ throw ex;
+ }
+ }
+ }
+
monitor.done();
}
« no previous file with comments | « no previous file | runtime/bin/dbg_message.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698