Pass dashing info from drawPath to Gr side

Pass dashing info from drawPath to Gr side

Pass dashing info also from drawPath calls to gpu path rendering code.
Previously dashing info was preserved only for fast-pathed drawRects and
such.

This enables path renderers to see dashing info for arbitrary paths.

Committed: https://skia.googlesource.com/skia/+/280a9c81aa38271bc3b8ad4d442dd894cd2af3db

[Kimmo Kinnunen, 2015-04-28 08:51:04]

kkinnunen@nvidia.com changed reviewers:
+ egdaniel@google.com

[egdaniel, 2015-04-28 13:25:48]

https://codereview.chromium.org/1114463002/diff/1/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.chromium.org/1114463002/diff/1/src/gpu/SkGpuDevice.cpp#new...
src/gpu/SkGpuDevice.cpp:846: if (stroke.applyToPath(strokedPath, *pathPtr)) {
what happens if both these if statements trigger and we filter/stroke the path
twice? seems like the stroke would take the original path and stroke it.

[Kimmo Kinnunen, 2015-04-28 14:12:30]

https://codereview.chromium.org/1114463002/diff/1/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.chromium.org/1114463002/diff/1/src/gpu/SkGpuDevice.cpp#new...
src/gpu/SkGpuDevice.cpp:846: if (stroke.applyToPath(strokedPath, *pathPtr)) {
On 2015/04/28 13:25:48, egdaniel wrote:
> what happens if both these if statements trigger and we filter/stroke the path
> twice?

Yeah, the intention is to first apply the dashing and then apply the stroking.

> seems like the stroke would take the original path and stroke it.

The intention is to apply the dash to the original path and store that to
stroked path. Then the idea is to stroke that and store the result to the
stroked path.

[egdaniel, 2015-04-28 14:18:19]

https://codereview.chromium.org/1114463002/diff/1/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.chromium.org/1114463002/diff/1/src/gpu/SkGpuDevice.cpp#new...
src/gpu/SkGpuDevice.cpp:846: if (stroke.applyToPath(strokedPath, *pathPtr)) {
On 2015/04/28 14:12:30, Kimmo Kinnunen wrote:
> On 2015/04/28 13:25:48, egdaniel wrote:
> > what happens if both these if statements trigger and we filter/stroke the
path
> > twice?
> 
> Yeah, the intention is to first apply the dashing and then apply the stroking.
> 
> > seems like the stroke would take the original path and stroke it.
> 
> The intention is to apply the dash to the original path and store that to
> stroked path. Then the idea is to stroke that and store the result to the
> stroked path.

So if on line 838, if !pathIsMutable then strokedPath = tmpPath. Then we take
pathPtr (original path), "dash" it, and store the result into strokedPath
(tmpPath). Then when we try to apply the stroke to path, we use pathPtr as the
source again. This value wasn't updated in the "dashing" block so we end up
stroking the original path and not the dashed one. Or am I missing something?

[egdaniel, 2015-04-28 14:20:09]

https://codereview.chromium.org/1114463002/diff/1/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.chromium.org/1114463002/diff/1/src/gpu/SkGpuDevice.cpp#new...
src/gpu/SkGpuDevice.cpp:846: if (stroke.applyToPath(strokedPath, *pathPtr)) {
On 2015/04/28 14:18:19, egdaniel wrote:
> On 2015/04/28 14:12:30, Kimmo Kinnunen wrote:
> > On 2015/04/28 13:25:48, egdaniel wrote:
> > > what happens if both these if statements trigger and we filter/stroke the
> path
> > > twice?
> > 
> > Yeah, the intention is to first apply the dashing and then apply the
stroking.
> > 
> > > seems like the stroke would take the original path and stroke it.
> > 
> > The intention is to apply the dash to the original path and store that to
> > stroked path. Then the idea is to stroke that and store the result to the
> > stroked path.
> 
> So if on line 838, if !pathIsMutable then strokedPath = tmpPath. Then we take
> pathPtr (original path), "dash" it, and store the result into strokedPath
> (tmpPath). Then when we try to apply the stroke to path, we use pathPtr as the
> source again. This value wasn't updated in the "dashing" block so we end up
> stroking the original path and not the dashed one. Or am I missing something?

oh wait I am missing a line. woops ignore all my stupidity.

[egdaniel, 2015-04-28 14:27:15]

lgtm

[Kimmo Kinnunen, 2015-04-29 05:15:07]

The CQ bit was checked by kkinnunen@nvidia.com

[commit-bot: I haz the power, 2015-04-29 05:15:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1114463002/1

[commit-bot: I haz the power, 2015-04-29 05:19:29]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/280a9c81aa38271bc3b8ad4d442dd894cd2af3db