Issue 1114453002: use 'branding_path_component' to simplify branding in chrome directory - part 2

Issue 1114453002: use 'branding_path_component' to simplify branding in chrome directory - part 2 (Closed)

Created:
5 years, 8 months ago by gburanov

Modified:
5 years, 7 months ago

Reviewers:
cpu_(ooo_6.6-7.5), sky

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

use 'branding_path_component' to simplify branding in chrome main directory (and crash service) - part 2 Also in context of this review crash service is also using 'branding_path_component' Please take look at https://codereview.chromium.org/1090213002/patch/40001/50001 for details BUG= Committed: https://crrev.com/eaf365a0d6373700b3cb8d51a6de09e52039461c Cr-Commit-Position: refs/heads/master@{#327388}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -27 lines)			Patch
M	chrome/chrome.gyp	View	1 chunk	+2 lines, -9 lines	0 comments	Download
M	chrome/chrome_dll_bundle.gypi	View	1 chunk	+1 line, -7 lines	0 comments	Download
M	chrome/tools/crash_service/caps/caps.gyp	View	1 chunk	+1 line, -11 lines	0 comments	Download

Total messages: 8 (2 generated)

gburanov

Please take a look cpu@chromium org - crash tools sky - main chrome directory

5 years, 8 months ago (2015-04-28 07:45:19 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1114453002/1

5 years, 7 months ago (2015-04-28 21:48:52 UTC) #6

commit-bot: I haz the power

5 years, 7 months ago (2015-04-28 23:26:04 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/eaf365a0d6373700b3cb8d51a6de09e52039461c
Cr-Commit-Position: refs/heads/master@{#327388}