Issue 111443014: Use default argument value instead of overloading for MarkupAccumulator::serializeNodes()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 111443014: Use default argument value instead of overloading for MarkupAccumulator::serializeNodes() (Closed)

Created:
6 years, 11 months ago by Inactive

Modified:
6 years, 11 months ago

Reviewers:
adamk

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@dom_WATCHLIST

Visibility:
Public.

More Reviews

Description

Use default argument value instead of overloading for MarkupAccumulator::serializeNodes() The last argument to MarkupAccumulator::serializeNodes() was optional and we were dealing with this using overloads instead of having a default value for the last argument. This makes the code a bit cleaner / shorter. R=adamk BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164601

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -7 lines)			Patch
	M	Source/core/editing/MarkupAccumulator.h	View		1 chunk	+1 line, -2 lines	0 comments	Download
	M	Source/core/editing/MarkupAccumulator.cpp	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/111443014/1

6 years, 11 months ago (2014-01-07 18:12:23 UTC) #3

Message was sent while issue was closed.

Change committed as 164601

Expand Messages | Collapse Messages