Issue 111443011: Set m_nextBreakablePosition as private in InlineIterator, and use it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 111443011: Set m_nextBreakablePosition as private in InlineIterator, and use it (Closed)

Created:
6 years, 12 months ago by gyuyoung-inactive

Modified:
6 years, 11 months ago

Reviewers:
pdr.

CC:
blink-reviews, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, zoltan1

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Set m_nextBreakablePosition as private in InlineIterator, and use it InlineIterator has been exported m_nextBreakablePosition as public though it is member variable. This patch set it as private, and add getter/setter functions for it. Merge from WebKit r160413. BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164371

Patch Set 1 #

Created: 6 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -10 lines)			Patch
	M	Source/core/rendering/InlineIterator.h	View		4 chunks	+8 lines, -4 lines	0 comments	Download
	M	Source/core/rendering/line/BreakingContextInlineHeaders.h	View		6 chunks	+8 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/111443011/1

6 years, 11 months ago (2013-12-30 05:52:44 UTC) #3

Message was sent while issue was closed.

Change committed as 164371

Expand Messages | Collapse Messages