Multiprofiles: cancellation of adding a profile on ESC-pressing at account picker screen.

Cancel on ESC added for login screen.

BUG=315625
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241250

[dzhioev (left Google), 2013-12-16 15:22:54]

https://codereview.chromium.org/111443008/diff/1/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/login/screen_account_picker.js (right):

https://codereview.chromium.org/111443008/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/screen_account_picker.js:82:
chrome.send('cancelUserAdding');
Check if display type == DISPLAY_TYPE.USER_ADDING.

[merkulova, 2013-12-16 15:32:41]

https://codereview.chromium.org/111443008/diff/1/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/login/screen_account_picker.js (right):

https://codereview.chromium.org/111443008/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/screen_account_picker.js:82:
chrome.send('cancelUserAdding');
On 2013/12/16 15:22:54, dzhioev wrote:
> Check if display type == DISPLAY_TYPE.USER_ADDING.

Done.

[dzhioev (left Google), 2013-12-16 15:41:05]

Please clarify description.

https://codereview.chromium.org/111443008/diff/20001/chrome/browser/resources...
File chrome/browser/resources/chromeos/login/screen_account_picker.js (right):

https://codereview.chromium.org/111443008/diff/20001/chrome/browser/resources...
chrome/browser/resources/chromeos/login/screen_account_picker.js:82: if
(Oobe.getInstance().displayType_ == 'user-adding')
Use getter 'displayType()' instead of internal property 'displayType_'. Use
constant DISPLAY_TYPE.USER_ADDING instead of 'user-adding'.

[merkulova, 2013-12-16 15:47:04]

https://codereview.chromium.org/111443008/diff/20001/chrome/browser/resources...
File chrome/browser/resources/chromeos/login/screen_account_picker.js (right):

https://codereview.chromium.org/111443008/diff/20001/chrome/browser/resources...
chrome/browser/resources/chromeos/login/screen_account_picker.js:82: if
(Oobe.getInstance().displayType_ == 'user-adding')
On 2013/12/16 15:41:05, dzhioev wrote:
> Use getter 'displayType()' instead of internal property 'displayType_'. Use
> constant DISPLAY_TYPE.USER_ADDING instead of 'user-adding'.

Done.

[dzhioev (left Google), 2013-12-16 15:54:11]

Clarify description.


On Mon, Dec 16, 2013 at 7:47 PM, <merkulova@chromium.org> wrote:

>
> https://codereview.chromium.org/111443008/diff/20001/
> chrome/browser/resources/chromeos/login/screen_account_picker.js
> File chrome/browser/resources/chromeos/login/screen_account_picker.js
> (right):
>
> https://codereview.chromium.org/111443008/diff/20001/
> chrome/browser/resources/chromeos/login/screen_account_picker.js#newcode82
> chrome/browser/resources/chromeos/login/screen_account_picker.js:82: if
> (Oobe.getInstance().displayType_ == 'user-adding')
> On 2013/12/16 15:41:05, dzhioev wrote:
>
>> Use getter 'displayType()' instead of internal property
>>
> 'displayType_'. Use
>
>> constant DISPLAY_TYPE.USER_ADDING instead of 'user-adding'.
>>
>
> Done.
>
> https://codereview.chromium.org/111443008/
>



-- 
Pavel Sergeev

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dzhioev (left Google), 2013-12-16 16:06:08]

On 2013/12/16 15:54:11, dzhioev wrote:
> Clarify description.
> 
> 
> On Mon, Dec 16, 2013 at 7:47 PM, <mailto:merkulova@chromium.org> wrote:
> 
> >
> > https://codereview.chromium.org/111443008/diff/20001/
> > chrome/browser/resources/chromeos/login/screen_account_picker.js
> > File chrome/browser/resources/chromeos/login/screen_account_picker.js
> > (right):
> >
> > https://codereview.chromium.org/111443008/diff/20001/
> > chrome/browser/resources/chromeos/login/screen_account_picker.js#newcode82
> > chrome/browser/resources/chromeos/login/screen_account_picker.js:82: if
> > (Oobe.getInstance().displayType_ == 'user-adding')
> > On 2013/12/16 15:41:05, dzhioev wrote:
> >
> >> Use getter 'displayType()' instead of internal property
> >>
> > 'displayType_'. Use
> >
> >> constant DISPLAY_TYPE.USER_ADDING instead of 'user-adding'.
> >>
> >
> > Done.
> >
> > https://codereview.chromium.org/111443008/
> >
> 
> 
> 
> -- 
> Pavel Sergeev
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

LGTM

[commit-bot: I haz the power, 2013-12-16 16:07:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/merkulova@chromium.org/111443008/40001

[commit-bot: I haz the power, 2013-12-16 19:18:07]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-12-17 09:42:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/merkulova@chromium.org/111443008/40001

[commit-bot: I haz the power, 2013-12-17 10:47:13]

Change committed as 241250