Skip plugins/update-widgets-crash.html on Linux.

Skip plugins/update-widgets-crash.html on Linux.

It was previously skipped with the rest of plugins/ and
it was not intended to re-enable it.

BUG=483489, 476590, 457054
TBR=schenney@chromium.org,bbudge@chromium.org
NOTRY=true
NOTREECHECKS=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194821

[jbroman, 2015-05-01 18:21:25]

jbroman@chromium.org changed reviewers:
+ bbudge@chromium.org, schenney@chromium.org

[jbroman, 2015-05-01 18:22:01]

I'm not sure what the issue with this test is, but it's flakily timing out on
Linux, rather than failing like on Windows.

I'm assuming it's a related issue, so I'm just landing an expectations change.

[jbroman, 2015-05-01 18:22:04]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2015-05-01 18:22:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1114413002/1

[Stephen Chennney, 2015-05-01 18:25:55]

On 2015/05/01 18:22:01, jbroman wrote:
> I'm not sure what the issue with this test is, but it's flakily timing out on
> Linux, rather than failing like on Windows.
> 
> I'm assuming it's a related issue, so I'm just landing an expectations change.

There's a line in TestExpectations,

crbug.com/318978 [ Linux ] plugins/ [ Skip ]

that should be disabling all the plugins tests. I think that if there's any
other expectation for a file skipped by directory then the test still runs. I
think this is a bug, but it also makes me think you could skip that specific
test on Linux - it was skipped before that new expectation went in.

[jbroman, 2015-05-01 18:26:50]

The CQ bit was unchecked by jbroman@chromium.org

[jbroman, 2015-05-01 18:27:26]

On 2015/05/01 18:25:55, Stephen Chenney wrote:
> On 2015/05/01 18:22:01, jbroman wrote:
> > I'm not sure what the issue with this test is, but it's flakily timing out
on
> > Linux, rather than failing like on Windows.
> > 
> > I'm assuming it's a related issue, so I'm just landing an expectations
change.
> 
> There's a line in TestExpectations,
> 
> crbug.com/318978 [ Linux ] plugins/ [ Skip ]
> 
> that should be disabling all the plugins tests. I think that if there's any
> other expectation for a file skipped by directory then the test still runs. I
> think this is a bug, but it also makes me think you could skip that specific
> test on Linux - it was skipped before that new expectation went in.

Ah, that explains it. It's weird that it works that way. Will adjust this CL to
skip instead.
(And congrats on beating blink_presubmit for first to read this CL.)

[jbroman, 2015-05-01 18:29:47]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2015-05-01 18:30:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1114413002/20001

[jbroman, 2015-05-01 18:44:11]

Committed patchset #2 (id:20001) manually as 194821 (presubmit successful).

[Noel Gordon, 2015-05-01 23:36:48]

LGTM

On 2015/05/01 18:27:26, jbroman wrote:
> Ah, that explains it. It's weird that it works that way.

++