Fix race condition when posting debugger messages to the message queue

bin/dbg_message.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/dbg_connection.h"
 #include "bin/dbg_message.h"
 #include "bin/dartutils.h"
 #include "bin/thread.h"
 #include "bin/utils.h"
 
@@ skipping 827 matching lines @@
       msglist_tail_ = NULL;
     }
   }
   is_interrupted_ = false;
   is_running_ = true;
 }
 
 
 void DbgMsgQueue::InterruptIsolate() {
   Dart_Isolate isolate = Dart_GetIsolate(isolate_id_);
-  ASSERT(DbgMsgQueueList::GetIsolateMsgQueue(isolate_id_) == this);
   MonitorLocker ml(&msg_queue_lock_);
   if (is_running_ && !is_interrupted_) {
     is_interrupted_ = true;
     Dart_InterruptIsolate(isolate);
   }
 }
 
 
 void DbgMsgQueue::QueueOutputMsg(dart::TextBuffer* msg) {
   queued_output_messages_.Printf("%s", msg->buf());
@@ skipping 84 matching lines @@
   while (debugger_commands[i].cmd_string != NULL) {
     if (strncmp(buf, debugger_commands[i].cmd_string, buflen) == 0) {
       return i;
     }
     i++;
   }
   return kInvalidCommand;
 }
 
 
+bool DbgMsgQueueList::AddIsolateMessage(Dart_IsolateId isolate_id,
+                                        int32_t cmd_idx,
+                                        const char* start,
+                                        const char* end,
+                                        int debug_fd) {
+  MutexLocker ml(&msg_queue_list_lock_);
+  DbgMsgQueue* queue = DbgMsgQueueList::GetIsolateMsgQueueLocked(isolate_id);
+  if (queue != NULL) {
+    queue->AddMessage(cmd_idx, start, end, debug_fd);
+    return true;
+  }
+  return false;
+}
+
+
+bool DbgMsgQueueList::InterruptIsolate(Dart_IsolateId isolate_id) {
+  MutexLocker ml(&msg_queue_list_lock_);
+  DbgMsgQueue* queue = DbgMsgQueueList::GetIsolateMsgQueueLocked(isolate_id);
+  if (queue != NULL) {
+    queue->InterruptIsolate();
+    return true;
+  }
+  return false;
+}
+
+
 DbgMsgQueue* DbgMsgQueueList::AddIsolateMsgQueue(Dart_IsolateId isolate_id) {
   MutexLocker ml(&msg_queue_list_lock_);
 
   DbgMsgQueue* queue = new DbgMsgQueue(isolate_id, list_);
   ASSERT(queue != NULL);
   list_ = queue;
   return queue;
 }
 
 
 DbgMsgQueue* DbgMsgQueueList::GetIsolateMsgQueue(Dart_IsolateId isolate_id) {
   MutexLocker ml(&msg_queue_list_lock_);
+  ASSERT(Dart_GetIsolate(isolate_id) == Dart_CurrentIsolate());
+  return GetIsolateMsgQueueLocked(isolate_id);
+}
 
+
+DbgMsgQueue* DbgMsgQueueList::GetIsolateMsgQueueLocked(Dart_IsolateId id) {
   if (list_ == NULL) {
     return NULL;  // No items in the list.
   }
 
   // TODO(asiva): Remove once debug wire protocol has isolate id.
   // For now we return the first item in the list as we are only supporting
   // debugging of a single isolate.
-  if (isolate_id == ILLEGAL_ISOLATE_ID) {
+  if (id == ILLEGAL_ISOLATE_ID) {
     return list_;
   }
 
   // Find message queue corresponding to isolate id.
   DbgMsgQueue* iterator = list_;
-  while (iterator != NULL && iterator->isolate_id() != isolate_id) {
+  while (iterator != NULL && iterator->isolate_id() != id) {
     iterator = iterator->next();
   }
   return iterator;
 }
 
 
 void DbgMsgQueueList::RemoveIsolateMsgQueue(Dart_IsolateId isolate_id) {
   MutexLocker ml(&msg_queue_list_lock_);
   if (list_ == NULL) {
     return;  // No items in the list.
@@ skipping 17 matching lines @@
     }
   }
   UNREACHABLE();
 }
 
 
 void DbgMsgQueueList::BptResolvedHandler(Dart_IsolateId isolate_id,
                                          intptr_t bp_id,
                                          Dart_Handle url,
                                          intptr_t line_number) {
-  ASSERT(Dart_GetIsolate(isolate_id) == Dart_CurrentIsolate());
   Dart_EnterScope();
   dart::TextBuffer msg(128);
   msg.Printf("{ \"event\": \"breakpointResolved\", \"params\": {");
   msg.Printf("\"breakpointId\": %"Pd", \"url\":", bp_id);
   FormatEncodedString(&msg, url);
   msg.Printf(",\"line\": %"Pd" }}", line_number);
   DbgMsgQueue* msg_queue = GetIsolateMsgQueue(isolate_id);
   ASSERT(msg_queue != NULL);
   msg_queue->QueueOutputMsg(&msg);
   Dart_ExitScope();
 }
 
 
 void DbgMsgQueueList::BreakpointHandler(Dart_IsolateId isolate_id,
                                         Dart_Breakpoint bpt,
                                         Dart_StackTrace trace) {
-  ASSERT(Dart_GetIsolate(isolate_id) == Dart_CurrentIsolate());
   DebuggerConnectionHandler::WaitForConnection();
   Dart_EnterScope();
   DbgMsgQueue* msg_queue = GetIsolateMsgQueue(isolate_id);
   ASSERT(msg_queue != NULL);
   msg_queue->SendQueuedMsgs();
   msg_queue->SendBreakpointEvent(trace);
   msg_queue->HandleMessages();
   Dart_ExitScope();
 }
 
 
 void DbgMsgQueueList::ExceptionThrownHandler(Dart_IsolateId isolate_id,
                                              Dart_Handle exception,
                                              Dart_StackTrace stack_trace) {
-  ASSERT(Dart_GetIsolate(isolate_id) == Dart_CurrentIsolate());
   DebuggerConnectionHandler::WaitForConnection();
   Dart_EnterScope();
   DbgMsgQueue* msg_queue = GetIsolateMsgQueue(isolate_id);
   ASSERT(msg_queue != NULL);
   msg_queue->SendQueuedMsgs();
   msg_queue->SendExceptionEvent(exception, stack_trace);
   msg_queue->HandleMessages();
   Dart_ExitScope();
 }
 
 
 void DbgMsgQueueList::IsolateEventHandler(Dart_IsolateId isolate_id,
                                           Dart_IsolateEvent kind) {
   DebuggerConnectionHandler::WaitForConnection();
   Dart_EnterScope();
   if (kind == kCreated) {
     DbgMsgQueue* msg_queue = AddIsolateMsgQueue(isolate_id);
     msg_queue->SendIsolateEvent(isolate_id, kind);
   } else {
-    ASSERT(Dart_GetIsolate(isolate_id) == Dart_CurrentIsolate());
     DbgMsgQueue* msg_queue = GetIsolateMsgQueue(isolate_id);
     ASSERT(msg_queue != NULL);
     msg_queue->SendQueuedMsgs();
     msg_queue->SendIsolateEvent(isolate_id, kind);
     if (kind == kInterrupted) {
       msg_queue->HandleMessages();
     } else {
       ASSERT(kind == kShutdown);
       RemoveIsolateMsgQueue(isolate_id);
     }
   }
   Dart_ExitScope();
 }