Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: runtime/lib/array.dart

Issue 11144016: Make argument of List.sort optional with default Comparable.compare. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 5
6 // TODO(srdjan): Use shared array implementation. 6 // TODO(srdjan): Use shared array implementation.
7 class _ObjectArray<E> implements List<E> { 7 class _ObjectArray<E> implements List<E> {
8 8
9 factory _ObjectArray(int length) native "ObjectArray_allocate"; 9 factory _ObjectArray(int length) native "ObjectArray_allocate";
10 10
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 } 85 }
86 86
87 bool some(bool f(E element)) { 87 bool some(bool f(E element)) {
88 return Collections.some(this, f); 88 return Collections.some(this, f);
89 } 89 }
90 90
91 bool isEmpty() { 91 bool isEmpty() {
92 return this.length === 0; 92 return this.length === 0;
93 } 93 }
94 94
95 void sort(int compare(E a, E b)) { 95 void sort([Comparator<E> compare = Comparable.compare]) {
96 DualPivotQuicksort.sort(this, compare); 96 DualPivotQuicksort.sort(this, compare);
97 } 97 }
98 98
99 int indexOf(E element, [int start = 0]) { 99 int indexOf(E element, [int start = 0]) {
100 return Arrays.indexOf(this, element, start, this.length); 100 return Arrays.indexOf(this, element, start, this.length);
101 } 101 }
102 102
103 int lastIndexOf(E element, [int start = null]) { 103 int lastIndexOf(E element, [int start = null]) {
104 if (start === null) start = length - 1; 104 if (start === null) start = length - 1;
105 return Arrays.lastIndexOf(this, element, start); 105 return Arrays.lastIndexOf(this, element, start);
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
227 } 227 }
228 228
229 bool some(bool f(E element)) { 229 bool some(bool f(E element)) {
230 return Collections.some(this, f); 230 return Collections.some(this, f);
231 } 231 }
232 232
233 bool isEmpty() { 233 bool isEmpty() {
234 return this.length === 0; 234 return this.length === 0;
235 } 235 }
236 236
237 void sort(int compare(E a, E b)) { 237 void sort([Comparator<E> compare]) {
238 throw const UnsupportedOperationException( 238 throw const UnsupportedOperationException(
239 "Cannot modify an immutable array"); 239 "Cannot modify an immutable array");
240 } 240 }
241 241
242 String toString() { 242 String toString() {
243 return Collections.collectionToString(this); 243 return Collections.collectionToString(this);
244 } 244 }
245 245
246 int indexOf(E element, [int start = 0]) { 246 int indexOf(E element, [int start = 0]) {
247 return Arrays.indexOf(this, element, start, this.length); 247 return Arrays.indexOf(this, element, start, this.length);
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
306 if (!hasNext()) { 306 if (!hasNext()) {
307 throw const NoMoreElementsException(); 307 throw const NoMoreElementsException();
308 } 308 }
309 return _array[_pos++]; 309 return _array[_pos++];
310 } 310 }
311 311
312 final List<E> _array; 312 final List<E> _array;
313 final int _length; // Cache array length for faster access. 313 final int _length; // Cache array length for faster access.
314 int _pos; 314 int _pos;
315 } 315 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698