Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProvider

Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProvider
so that all provider subclasses can have their state verified.

Committed: https://crrev.com/bce10d97d6fc5233071427cf622aaad7abde9e19
Cr-Commit-Position: refs/heads/master@{#328154}

Committed: https://crrev.com/269875cf0d23881a7ad119bae730ff54fdd4dd0b
Cr-Commit-Position: refs/heads/master@{#328351}

Committed: https://crrev.com/d833a674a5e4f3b4e47f229b3d5411a8d509c2c0
Cr-Commit-Position: refs/heads/master@{#328909}

Committed: https://crrev.com/1d6f67fe72b4a9ae94fcb0a6e051d803a180bde1
Cr-Commit-Position: refs/heads/master@{#329003}

Committed: https://crrev.com/1f1b299125a49be4f4c5a514d3fe4eee13dc904b
Cr-Commit-Position: refs/heads/master@{#330139}

[Ryan Hamilton, 2015-05-01 19:12:43]

rch@chromium.org changed reviewers:
+ rtenneti@chromium.org

[ramant (doing other things), 2015-05-01 20:25:41]

lgtm

https://codereview.chromium.org/1114383003/diff/1/net/socket/socket_test_util.h
File net/socket/socket_test_util.h (right):

https://codereview.chromium.org/1114383003/diff/1/net/socket/socket_test_util...
net/socket/socket_test_util.h:263: // Return true of all read data has been
consumed.
overly nit: "true of all" -> "true if all"?

https://codereview.chromium.org/1114383003/diff/1/net/socket/socket_test_util...
net/socket/socket_test_util.h:266: // Return true of all write data has been
consumed.
overly nit: "true of all" -> "true if all"?

[Ryan Hamilton, 2015-05-01 21:23:33]

Thanks!

https://codereview.chromium.org/1114383003/diff/1/net/socket/socket_test_util.h
File net/socket/socket_test_util.h (right):

https://codereview.chromium.org/1114383003/diff/1/net/socket/socket_test_util...
net/socket/socket_test_util.h:263: // Return true of all read data has been
consumed.
On 2015/05/01 20:25:41, ramant wrote:
> overly nit: "true of all" -> "true if all"?

Done.

https://codereview.chromium.org/1114383003/diff/1/net/socket/socket_test_util...
net/socket/socket_test_util.h:266: // Return true of all write data has been
consumed.
On 2015/05/01 20:25:41, ramant wrote:
> overly nit: "true of all" -> "true if all"?

Done.

[Ryan Hamilton, 2015-05-01 21:23:36]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2015-05-01 21:23:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
rtenneti@chromium.org
Link to the patchset: https://codereview.chromium.org/1114383003/#ps20001
(title: "fix comments")

[commit-bot: I haz the power, 2015-05-01 21:24:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1114383003/20001

[commit-bot: I haz the power, 2015-05-01 21:38:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-01 21:38:05]

Try jobs failed on following builders:
  linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ryan Hamilton, 2015-05-01 23:08:54]

rch@chromium.org changed reviewers:
+ sergeyu@chromium.org

[Ryan Hamilton, 2015-05-01 23:08:54]

sergeyu: jingle/ and remoting/ ONWERS, please?

[Sergey Ulanov, 2015-05-04 17:19:47]

lgtm

[Ryan Hamilton, 2015-05-04 17:30:24]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2015-05-04 17:30:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
rtenneti@chromium.org
Link to the patchset: https://codereview.chromium.org/1114383003/#ps40001
(title: "ah, chromoting")

[commit-bot: I haz the power, 2015-05-04 17:31:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1114383003/40001

[commit-bot: I haz the power, 2015-05-04 18:21:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-05-04 18:22:33]

Patchset 3 (id:??) landed as
https://crrev.com/bce10d97d6fc5233071427cf622aaad7abde9e19
Cr-Commit-Position: refs/heads/master@{#328154}

[Dan Beam, 2015-05-05 03:54:38]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1119803006/ by dbeam@chromium.org.

The reason for reverting is: Final stop on the revert train!

net_unittests on iOS Simulator (dbg) (iPhone 5 ios 8.1) should be fixed after
this?
https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_(dbg)

Here's a log of the break:
https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/bu....

[Ryan Hamilton, 2015-05-05 14:52:57]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2015-05-05 14:52:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
sergeyu@chromium.org, rtenneti@chromium.org
Link to the patchset: https://codereview.chromium.org/1114383003/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2015-05-05 14:53:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1114383003/60001

[commit-bot: I haz the power, 2015-05-05 17:25:10]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-05-05 17:27:05]

Patchset 4 (id:??) landed as
https://crrev.com/269875cf0d23881a7ad119bae730ff54fdd4dd0b
Cr-Commit-Position: refs/heads/master@{#328351}

[piman, 2015-05-05 19:13:21]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1114353005/ by piman@chromium.org.

The reason for reverting is: Suspected cause of IOS failure
https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/bu....

[Ryan Hamilton, 2015-05-08 02:56:37]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2015-05-08 02:56:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
sergeyu@chromium.org, rtenneti@chromium.org
Link to the patchset: https://codereview.chromium.org/1114383003/#ps80001
(title: "more conservative")

[commit-bot: I haz the power, 2015-05-08 02:57:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1114383003/80001

[commit-bot: I haz the power, 2015-05-08 03:11:50]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-05-08 03:13:09]

Patchset 5 (id:??) landed as
https://crrev.com/d833a674a5e4f3b4e47f229b3d5411a8d509c2c0
Cr-Commit-Position: refs/heads/master@{#328909}

[Ryan Hamilton, 2015-05-08 03:59:48]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1123383004/ by rch@chromium.org.

The reason for reverting is: Even this revised patch seems to break on iOS.

http://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/bui...

WTF!?!?!?!!?.

[Ryan Hamilton, 2015-05-08 18:14:05]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2015-05-08 18:14:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
sergeyu@chromium.org, rtenneti@chromium.org
Link to the patchset: https://codereview.chromium.org/1114383003/#ps100001
(title: "Super conservative")

[commit-bot: I haz the power, 2015-05-08 18:14:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1114383003/100001

[commit-bot: I haz the power, 2015-05-08 19:09:09]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-05-08 19:10:28]

Patchset 6 (id:??) landed as
https://crrev.com/1d6f67fe72b4a9ae94fcb0a6e051d803a180bde1
Cr-Commit-Position: refs/heads/master@{#329003}

[Ryan Hamilton, 2015-05-08 19:33:02]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/1126113003/ by rch@chromium.org.

The reason for reverting is: Even adding methods which are not called breaks
this bot. How in the hell is this possible?

http://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/bui...

http://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/bui....

[mmenke, 2015-05-08 21:44:42]

On 2015/05/08 19:33:02, Ryan Hamilton wrote:
> A revert of this CL (patchset #6 id:100001) has been created in
> https://codereview.chromium.org/1126113003/ by mailto:rch@chromium.org.
> 
> The reason for reverting is: Even adding methods which are not called breaks
> this bot. How in the hell is this possible?
> 
>
http://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/bui...
> 
>
http://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/bui....

Hrm...  Short of something clobbering memory, or dereferencing a freed pointer,
I don't see how it is.

[Ryan Hamilton, 2015-05-15 17:38:25]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2015-05-15 17:38:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
sergeyu@chromium.org, rtenneti@chromium.org
Link to the patchset: https://codereview.chromium.org/1114383003/#ps120001
(title: "Rebase")

[commit-bot: I haz the power, 2015-05-15 17:39:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1114383003/120001

[commit-bot: I haz the power, 2015-05-15 18:29:53]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-05-15 18:30:51]

Patchset 7 (id:??) landed as
https://crrev.com/1f1b299125a49be4f4c5a514d3fe4eee13dc904b
Cr-Commit-Position: refs/heads/master@{#330139}