ash/system/overview/overview_button_tray.h - Issue 1114383002: Show overview mode button in TouchView with open modal window

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/system/overview/overview_button_tray.h

Issue 1114383002: Show overview mode button in TouchView with open modal window (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/system/overview/overview_button_tray.h

diff --git a/ash/system/overview/overview_button_tray.h b/ash/system/overview/overview_button_tray.h

index a58bae11576457979207ee82e858ef9781a91a46..ff7adf0f66708b8eb2d59d180a1045873e38dc15 100644

--- a/ash/system/overview/overview_button_tray.h

+++ b/ash/system/overview/overview_button_tray.h

@@ -52,8 +52,9 @@ class ASH_EXPORT OverviewButtonTray : public TrayBackgroundView,

// alignment of the shelf.

void SetIconBorderForShelfAlignment();

- // Sets the icon to visible if maximize mode is enabled and

- // WindowSelectorController::CanSelect.

+ // Shows or hides the overview button. The button be shown when the user is

bruthig 2015/05/01 17:43:34 nit: missing "will"? "The button be shown..."

tdanderson 2015/05/01 18:07:31 Done.

+ // in maximize mode and is in an active desktop environment, otherwise the

+ // button should be hidden.

void UpdateIconVisibility();

// Weak pointer, will be parented by TrayContainer for its lifetime.

« no previous file with comments | « no previous file | ash/system/overview/overview_button_tray.cc » ('j') | ash/system/overview/overview_button_tray_unittest.cc » ('J')