Make constructors recognize char[n] vs. char* and avoid strlen calls.

core/src/fpdfdoc/doc_metadata.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
  
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../include/fpdfdoc/fpdf_doc.h"
 #include "../../include/fxcrt/fx_xml.h"
 typedef struct _PDFDOC_METADATA {
     CPDF_Document *m_pDoc;
@@ skipping 52 matching lines @@
     FX_LPCBYTE pBuf = acc.GetData();
     CXML_Element *&pXmlElmnt = ((PDFDOC_LPMETADATA)m_pData)->m_pXmlElmnt;
     pXmlElmnt = CXML_Element::Parse(pBuf, size);
     if (!pXmlElmnt) {
         return;
     }
     CXML_Element *&pElmntRdf = ((PDFDOC_LPMETADATA)m_pData)->m_pElmntRdf;
     if (pXmlElmnt->GetTagName() == FX_BSTRC("RDF")) {
         pElmntRdf = pXmlElmnt;
     } else {
-        pElmntRdf = pXmlElmnt->GetElement(NULL, FX_BSTRC("RDF"));
+        pElmntRdf = pXmlElmnt->GetElement(CFX_ByteStringC(), FX_BSTRC("RDF"));
     }
 }
 FX_INT32 CPDF_Metadata::GetString(FX_BSTR bsItem, CFX_WideString &wsStr)
 {
     if (!((PDFDOC_LPMETADATA)m_pData)->m_pXmlElmnt) {
         return -1;
     }
     if (!((PDFDOC_LPMETADATA)m_pData)->m_pStringMap) {
         return -1;
     }
     void *szTag;
     if (!((PDFDOC_LPMETADATA)m_pData)->m_pStringMap->Lookup(bsItem, szTag)) {
         return -1;
     }
     CFX_ByteString bsTag = (FX_LPCSTR)szTag;
     wsStr = L"";
     CXML_Element *pElmntRdf = ((PDFDOC_LPMETADATA)m_pData)->m_pElmntRdf;
     if (!pElmntRdf) {
         return -1;
     }
     int nChild = pElmntRdf->CountChildren();
     for (int i = 0; i < nChild; i++) {
-        CXML_Element *pTag = pElmntRdf->GetElement(NULL, FX_BSTRC("Description"), i);
+        CXML_Element *pTag = pElmntRdf->GetElement(CFX_ByteStringC(), "Description", i);
         if (!pTag) {
             continue;
         }
         if (bsItem == FX_BSTRC("Title") || bsItem == FX_BSTRC("Subject")) {
-            CXML_Element *pElmnt = pTag->GetElement(NULL, bsTag);
+            CXML_Element *pElmnt = pTag->GetElement(CFX_ByteString(), bsTag);
             if (!pElmnt) {
                 continue;
             }
-            pElmnt = pElmnt->GetElement(NULL, FX_BSTRC("Alt"));
+            pElmnt = pElmnt->GetElement(CFX_ByteString(), FX_BSTRC("Alt"));
             if (!pElmnt) {
                 continue;
             }
-            pElmnt = pElmnt->GetElement(NULL, FX_BSTRC("li"));
+            pElmnt = pElmnt->GetElement(CFX_ByteString(), FX_BSTRC("li"));
             if (!pElmnt) {
                 continue;
             }
             wsStr = pElmnt->GetContent(0);
             return wsStr.GetLength();
         } else if (bsItem == FX_BSTRC("Author")) {
-            CXML_Element *pElmnt = pTag->GetElement(NULL, bsTag);
+            CXML_Element *pElmnt = pTag->GetElement(CFX_ByteString(), bsTag);
             if (!pElmnt) {
                 continue;
             }
-            pElmnt = pElmnt->GetElement(NULL, FX_BSTRC("Seq"));
+            pElmnt = pElmnt->GetElement(CFX_ByteString(), FX_BSTRC("Seq"));
             if (!pElmnt) {
                 continue;
             }
-            pElmnt = pElmnt->GetElement(NULL, FX_BSTRC("li"));
+            pElmnt = pElmnt->GetElement(CFX_ByteString(), FX_BSTRC("li"));
             if (!pElmnt) {
                 continue;
             }
             wsStr = pElmnt->GetContent(0);
             return wsStr.GetLength();
         } else {
-            CXML_Element *pElmnt = pTag->GetElement(NULL, bsTag);
+            CXML_Element *pElmnt = pTag->GetElement(CFX_ByteString(), bsTag);
             if (!pElmnt) {
                 continue;
             }
             wsStr = pElmnt->GetContent(0);
             return wsStr.GetLength();
         }
     }
     return -1;
 }
 CXML_Element* CPDF_Metadata::GetRoot() const
 {
     return ((PDFDOC_LPMETADATA)m_pData)->m_pXmlElmnt;
 }
 CXML_Element* CPDF_Metadata::GetRDF() const
 {
     return ((PDFDOC_LPMETADATA)m_pData)->m_pElmntRdf;
 }