Attempt at fixing crash in balloon code. The current code does a

chrome/browser/ui/views/notifications/balloon_view_views.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/notifications/balloon_view_views.h"
 
 #include <algorithm>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 75 matching lines @@
 const SkColor kControlBarSeparatorLineColor = SkColorSetRGB(180, 180, 180);
 
 }  // namespace
 
 BalloonViewImpl::BalloonViewImpl(BalloonCollection* collection)
     : balloon_(NULL),
       collection_(collection),
       frame_container_(NULL),
       html_container_(NULL),
       html_contents_(NULL),
-      method_factory_(this),
       close_button_(NULL),
       animation_(NULL),
       options_menu_model_(NULL),
       options_menu_button_(NULL),
-      enable_web_ui_(false) {
-  // This object is not to be deleted by the views hierarchy,
-  // as it is owned by the balloon.
+      enable_web_ui_(false),
+      closed_by_user_(false) {
+  // We're owned by Balloon and don't want to be deleted by our parent View.
   set_owned_by_client();
 
   views::BubbleBorder* bubble_border =
       new views::BubbleBorder(views::BubbleBorder::FLOAT,
                               views::BubbleBorder::NO_SHADOW);
   set_border(bubble_border);
 }
 
 BalloonViewImpl::~BalloonViewImpl() {
 }
 
 void BalloonViewImpl::Close(bool by_user) {
   animation_->Stop();
   html_contents_->Shutdown();
   // Detach contents from widget before then close.
   // This is necessary because a widget may be deleted
   // after this when chrome is shutting down.
   html_container_->GetRootView()->RemoveAllChildViews(true);
   html_container_->Close();
   frame_container_->GetRootView()->RemoveAllChildViews(true);
   frame_container_->Close();
-  // Post the tast at the end to sure this this WidgetDelegate
-  // instance is avaiable when Widget::CloseNow gets called.
-  MessageLoop::current()->PostTask(FROM_HERE,
-                                   base::Bind(&BalloonViewImpl::DelayedClose,
-                                              method_factory_.GetWeakPtr(),
-                                              by_user));
+  closed_by_user_ = by_user;
+  // |frame_container_->::Close()| is async. When processed it'll call back to
+  // DeleteDelegate() and we'll cleanup.

[stevenjb, 2012/10/16 16:43:41]

nit: it will, we will

[sky, 2012/10/16 16:45:06]

What's wrong with contractions?

[stevenjb, 2012/10/16 16:59:53]

Strunk & White says don't use them :) But they can be challenging for non native
speakers, especially less common ones. Just a nit :) Feel free to disregard.

 }
 
 gfx::Size BalloonViewImpl::GetSize() const {
   // BalloonView has no size if it hasn't been shown yet (which is when
   // balloon_ is set).
   if (!balloon_)
     return gfx::Size(0, 0);
 
   return gfx::Size(GetTotalWidth(), GetTotalHeight());
 }
@@ skipping 21 matching lines @@
 }
 
 void BalloonViewImpl::OnDisplayChanged() {
   collection_->DisplayChanged();
 }
 
 void BalloonViewImpl::OnWorkAreaChanged() {
   collection_->DisplayChanged();
 }
 
+void BalloonViewImpl::DeleteDelegate() {
+  balloon_->OnClose(closed_by_user_);
+}
+
 void BalloonViewImpl::ButtonPressed(views::Button* sender,
                                     const ui::Event&) {
   // The only button currently is the close button.
   DCHECK(sender == close_button_);
   Close(true);
 }
 
-void BalloonViewImpl::DelayedClose(bool by_user) {
-  balloon_->OnClose(by_user);
-}
-
 gfx::Size BalloonViewImpl::GetPreferredSize() {
   return gfx::Size(1000, 1000);
 }
 
 void BalloonViewImpl::SizeContentsWindow() {
   if (!html_container_ || !frame_container_)
     return;
 
   gfx::Rect contents_rect = GetContentsRectangle();
   html_container_->SetBounds(contents_rect);
@@ skipping 340 matching lines @@
     return;
   }
 
   // If the renderer process attached to this balloon is disconnected
   // (e.g., because of a crash), we want to close the balloon.
   notification_registrar_.Remove(
       this, chrome::NOTIFICATION_NOTIFY_BALLOON_DISCONNECTED,
       content::Source<Balloon>(balloon_));
   Close(false);
 }