Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11143027: cc: Remove wtf includes from *LayerTextureUpdater headers (Closed)

Created:
8 years, 2 months ago by enne (OOO)
Modified:
8 years, 2 months ago
Reviewers:
jamesr
CC:
chromium-reviews, cc-bugs_chromium.org, tfarina
Visibility:
Public.

Description

cc: Remove wtf includes from *LayerTextureUpdater headers BUG=154451 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162152

Patch Set 1 #

Total comments: 1

Patch Set 2 : Out of line CBCLTU dtor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -73 lines) Patch
M cc/bitmap_canvas_layer_texture_updater.h View 2 chunks +4 lines, -4 lines 0 comments Download
M cc/bitmap_canvas_layer_texture_updater.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M cc/bitmap_skpicture_canvas_layer_texture_updater.h View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/bitmap_skpicture_canvas_layer_texture_updater.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M cc/caching_bitmap_canvas_layer_texture_updater.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M cc/caching_bitmap_canvas_layer_texture_updater.cc View 1 2 chunks +8 lines, -2 lines 0 comments Download
M cc/canvas_layer_texture_updater.h View 1 chunk +1 line, -3 lines 0 comments Download
M cc/content_layer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/content_layer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/frame_buffer_skpicture_canvas_layer_texture_updater.h View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/frame_buffer_skpicture_canvas_layer_texture_updater.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M cc/image_layer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/image_layer.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M cc/layer_texture_updater.h View 4 chunks +10 lines, -9 lines 0 comments Download
M cc/scrollbar_layer.h View 1 chunk +6 lines, -6 lines 0 comments Download
M cc/scrollbar_layer.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M cc/skpicture_canvas_layer_texture_updater.h View 1 chunk +1 line, -2 lines 0 comments Download
M cc/test/tiled_layer_test_common.h View 3 chunks +5 lines, -3 lines 0 comments Download
M cc/test/tiled_layer_test_common.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/tiled_layer.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M cc/tiled_layer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
enne (OOO)
8 years, 2 months ago (2012-10-15 22:23:44 UTC) #1
jamesr
lgtm https://codereview.chromium.org/11143027/diff/1/cc/caching_bitmap_canvas_layer_texture_updater.h File cc/caching_bitmap_canvas_layer_texture_updater.h (right): https://codereview.chromium.org/11143027/diff/1/cc/caching_bitmap_canvas_layer_texture_updater.h#newcode31 cc/caching_bitmap_canvas_layer_texture_updater.h:31: virtual ~CachingBitmapCanvasLayerTextureUpdater() { } I'm surprised clang lets ...
8 years, 2 months ago (2012-10-15 22:27:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/11143027/5001
8 years, 2 months ago (2012-10-16 04:32:53 UTC) #3
commit-bot: I haz the power
Retried try job too often for step(s) browser_tests
8 years, 2 months ago (2012-10-16 06:42:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/11143027/5001
8 years, 2 months ago (2012-10-16 16:05:30 UTC) #5
commit-bot: I haz the power
8 years, 2 months ago (2012-10-16 17:32:52 UTC) #6 
Change committed as 162152

Powered by Google App Engine
This is Rietveld 408576698