Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 11143020: roll clang 163674:165787 (Closed)

Created:
8 years, 2 months ago by Nico
Modified:
8 years, 2 months ago
Reviewers:
Mark Mentovai, hans
CC:
chromium-reviews, fischman+watch_chromium.org, glotov+watch_chromium.org, pam+watch_chromium.org, ukai+watch_chromium.org
Visibility:
Public.

Description

roll clang 163674:165787 Also includes r165962 and r165963 on mac to fix a build issue. BUG=156005, 151927 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=162917

Patch Set 1 #

Patch Set 2 : plugin #

Patch Set 3 : plugin #

Patch Set 4 : warn :-/ #

Total comments: 1

Patch Set 5 : remove warning #

Patch Set 6 : rebase #

Patch Set 7 : warn again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M build/common.gypi View 1 2 3 4 5 6 2 chunks +4 lines, -0 lines 0 comments Download
M tools/clang/plugins/FindBadConstructs.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M tools/clang/scripts/plugin_flags.sh View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M tools/clang/scripts/update.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Nico
http://codereview.chromium.org/11143020/diff/4/tools/clang/plugins/FindBadConstructs.cpp File tools/clang/plugins/FindBadConstructs.cpp (right): http://codereview.chromium.org/11143020/diff/4/tools/clang/plugins/FindBadConstructs.cpp#newcode420 tools/clang/plugins/FindBadConstructs.cpp:420: llvm::errs() << "Unknown clang plugin argument: " << args[i] ...
8 years, 2 months ago (2012-10-15 21:48:27 UTC) #1
Nico
(cancelled due to asan issues) On Mon, Oct 15, 2012 at 2:48 PM, <thakis@chromium.org> wrote: ...
8 years, 2 months ago (2012-10-17 22:22:00 UTC) #2
Nico
+mark, hans is on vacation. The linux_asan issue doesn't repro locally and happens only spuriously ...
8 years, 2 months ago (2012-10-18 23:44:46 UTC) #3
Nico
…nevermind, looks like the cc stuff is still too big to build. Ignore for now.
8 years, 2 months ago (2012-10-18 23:52:06 UTC) #4
Mark Mentovai
LGTM
8 years, 2 months ago (2012-10-18 23:52:47 UTC) #5
Nico
On Thu, Oct 18, 2012 at 4:52 PM, <thakis@chromium.org> wrote: > …nevermind, looks like the ...
8 years, 2 months ago (2012-10-19 00:05:15 UTC) #6
commit-bot: I haz the power
8 years, 2 months ago (2012-10-19 00:27:14 UTC) #7

Powered by Google App Engine
This is Rietveld 408576698