Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Unified Diff: tools/create_sdk.py

Issue 11143010: Update revision info to version info for dart2js et al. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/utils.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/create_sdk.py
===================================================================
--- tools/create_sdk.py (revision 13566)
+++ tools/create_sdk.py (working copy)
@@ -103,12 +103,12 @@
Copy(src, dest)
-def CopyDart2Js(build_dir, sdk_root, revision):
- if revision:
+def CopyDart2Js(build_dir, sdk_root, version):
+ if version:
ReplaceInFiles([os.path.join(sdk_root, 'pkg', 'compiler',
'implementation', 'compiler.dart')],
[(r"BUILD_ID = 'build number could not be determined'",
- r"BUILD_ID = '%s'" % revision)])
+ r"BUILD_ID = '%s'" % version)])
if utils.GuessOS() == 'win32':
dart2js = os.path.join(sdk_root, 'bin', 'dart2js.bat')
Copy(os.path.join(build_dir, 'dart2js.bat'), dart2js)
@@ -318,15 +318,15 @@
"var pathTo7zip = '7zip/7za.exe';"),
])
- revision = utils.GetSVNRevision()
+ version = utils.GetVersion()
# Copy dart2js.
- CopyDart2Js(build_dir, SDK_tmp, revision)
+ CopyDart2Js(build_dir, SDK_tmp, version)
- # Write the 'revision' file
- if revision is not None:
- with open(os.path.join(SDK_tmp, 'revision'), 'w') as f:
- f.write(revision + '\n')
+ # Write the 'version' file
+ if version is not None:
+ with open(os.path.join(SDK_tmp, 'version'), 'w') as f:
+ f.write(version + '\n')
f.close()
Copy(join(HOME, 'README.dart-sdk'), join(SDK_tmp, 'README'))
« no previous file with comments | « no previous file | tools/utils.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698