Chromium Code Reviews
Help | Chromium Project | Sign in
(18)

Issue 11143005: Update ReceiverObjectNeedsWriteBarrier to include HFastLiteral (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 5 months ago by Jay Conrod
Modified:
2 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Update ReceiverObjectNeedsWriteBarrier to include HFastLiteral This will prevent unnecessary write barriers for literals. BUG=none TEST=none Committed: https://code.google.com/p/v8/source/detail?r=12823

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +2 lines, -1 line 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 2 (0 generated)
Michael Starzinger
LGTM. I'll rebase and land this. Just out of curiosity, did you find an application ...
2 years, 5 months ago (2012-10-25 15:31:15 UTC) #1
Jay Conrod
2 years, 5 months ago (2012-10-25 16:43:36 UTC) #2
I've mostly been experimenting on microbenchmarks. I didn't see a significant
improvement on the V8 benchmark, but I don't think object/array literals are
used that heavily there. Since the write barrier should never be executed in
this case, this mainly just reduces code size.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ecdb341-tainted