Issue 11143005: Update ReceiverObjectNeedsWriteBarrier to include HFastLiteral

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11143005: Update ReceiverObjectNeedsWriteBarrier to include HFastLiteral (Closed)

Created:
8 years, 2 months ago by Jay Conrod

Modified:
8 years, 1 month ago

Reviewers:
ulan, Michael Starzinger, danno

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Update ReceiverObjectNeedsWriteBarrier to include HFastLiteral This will prevent unnecessary write barriers for literals. BUG=none TEST=none Committed: https://code.google.com/p/v8/source/detail?r=12823

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	AUTHORS	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
	M	src/hydrogen-instructions.h	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM. I'll rebase and land this. Just out of curiosity, did you find an application ...

8 years, 1 month ago (2012-10-25 15:31:15 UTC) #1

Jay Conrod

8 years, 1 month ago (2012-10-25 16:43:36 UTC) #2

I've mostly been experimenting on microbenchmarks. I didn't see a significant
improvement on the V8 benchmark, but I don't think object/array literals are
used that heavily there. Since the write barrier should never be executed in
this case, this mainly just reduces code size.

Expand Messages | Collapse Messages