[Most Visited] Log suggestion provider to UMA

chrome/browser/search/most_visited_iframe_source.h

Index: chrome/browser/search/most_visited_iframe_source.h
diff --git a/chrome/browser/search/most_visited_iframe_source.h b/chrome/browser/search/most_visited_iframe_source.h
index 7344cc82724f920054e914ea0979733c0f9cd663..ec905ebc3d3b637fe8969c2cbd3000bc9b2b1c95 100644
--- a/chrome/browser/search/most_visited_iframe_source.h
+++ b/chrome/browser/search/most_visited_iframe_source.h
@@ -20,6 +20,9 @@ class MostVisitedIframeSource : public IframeSource {
   static const int kNumMostVisited;
   // Name of the histogram keeping track of Most Visited clicks.
   static const char kMostVisitedHistogramName[];
+  // Format string to generate the name of the histogram keeping track of MV
+  // clicks specific to a provider.
+  static const char kMostVisitedHistogramWithProvider[];

[Alexei Svitkine (slow), 2013/12/12 22:15:44]

Instead of exposing this constant directly and having your tests use
stringprintf on it, how about making a function that formats the histogram?
Then, the string constant can be local in the .cc file and the test can call the
function.

[Mathieu, 2013/12/13 15:01:38]

Done.

 
   // Overridden from IframeSource. Public for testing.
   virtual void StartDataRequest(