Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2630)

Unified Diff: chrome/browser/search/most_visited_iframe_source.h

Issue 111423005: [Most Visited] Log suggestion provider to UMA (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase? Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/search/most_visited_iframe_source.h
diff --git a/chrome/browser/search/most_visited_iframe_source.h b/chrome/browser/search/most_visited_iframe_source.h
index 7344cc82724f920054e914ea0979733c0f9cd663..c05d0d8024f6ee3ec853b13654a80e33a09546f0 100644
--- a/chrome/browser/search/most_visited_iframe_source.h
+++ b/chrome/browser/search/most_visited_iframe_source.h
@@ -7,6 +7,7 @@
#include "base/basictypes.h"
#include "base/compiler_specific.h"
+#include "base/gtest_prod_util.h"
#include "chrome/browser/search/iframe_source.h"
// Serves HTML for displaying suggestions using iframes, e.g.
@@ -34,6 +35,19 @@ class MostVisitedIframeSource : public IframeSource {
virtual bool ServesPath(const std::string& path) const OVERRIDE;
+ private:
+ FRIEND_TEST_ALL_PREFIXES(MostVisitedIframeSourceTest,
+ LogEndpointIsValidWithProvider);
+
+ // Logs the click on a Most Visited tile for a specific |provider|. Note that
+ // the UMA_HISTOGRAM_ENUMERATION macro cannot be used since it caches the
+ // histogram object at the call site, which will not work in this case.
+ void LogMostVisitedProviderClick(int position, const std::string& provider);
+
+ // Returns the name of the histogram that should be logged for a click to a
+ // specified Most Visited |provider|.
+ static std::string GetHistogramNameForProvider(const std::string& provider);
+
DISALLOW_COPY_AND_ASSIGN(MostVisitedIframeSource);
};
« no previous file with comments | « chrome/browser/resources/local_ntp/most_visited_util.js ('k') | chrome/browser/search/most_visited_iframe_source.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698