Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2190)

Unified Diff: chrome/browser/resources/local_ntp/most_visited_thumbnail.js

Issue 111423005: [Most Visited] Log suggestion provider to UMA (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase? Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/local_ntp/most_visited_title.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/local_ntp/most_visited_thumbnail.js
diff --git a/chrome/browser/resources/local_ntp/most_visited_thumbnail.js b/chrome/browser/resources/local_ntp/most_visited_thumbnail.js
index 4b2f305fc1f80cf656070936bbcf646b2095becc..9201259e31e8c30aa82b6f54fe21481bd88085a8 100644
--- a/chrome/browser/resources/local_ntp/most_visited_thumbnail.js
+++ b/chrome/browser/resources/local_ntp/most_visited_thumbnail.js
@@ -20,7 +20,7 @@ window.addEventListener('DOMContentLoaded', function() {
function showDomainElement() {
logEvent(NTP_LOGGING_EVENT_TYPE.NTP_THUMBNAIL_ERROR);
var link = createMostVisitedLink(
- params, data.url, data.title, undefined, data.ping);
+ params, data.url, data.title, undefined, data.ping, data.provider);
var domain = document.createElement('div');
domain.textContent = data.domain;
link.appendChild(domain);
@@ -30,7 +30,7 @@ window.addEventListener('DOMContentLoaded', function() {
// externally by the page itself.
function showEmptyTile() {
var link = createMostVisitedLink(
- params, data.url, data.title, undefined, data.ping);
+ params, data.url, data.title, undefined, data.ping, data.provider);
document.body.appendChild(link);
logEvent(NTP_LOGGING_EVENT_TYPE.NTP_EXTERNAL_TILE);
}
@@ -40,7 +40,7 @@ window.addEventListener('DOMContentLoaded', function() {
var shadow = document.createElement('span');
shadow.classList.add('shadow');
var link = createMostVisitedLink(
- params, data.url, data.title, undefined, data.ping);
+ params, data.url, data.title, undefined, data.ping, data.provider);
link.appendChild(shadow);
link.appendChild(image);
// We add 'position: absolute' in anticipation that there could be more
« no previous file with comments | « no previous file | chrome/browser/resources/local_ntp/most_visited_title.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698