Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Unified Diff: chrome/browser/search/most_visited_iframe_source.cc

Issue 111423005: [Most Visited] Log suggestion provider to UMA (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Cleaning Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/search/most_visited_iframe_source.cc
diff --git a/chrome/browser/search/most_visited_iframe_source.cc b/chrome/browser/search/most_visited_iframe_source.cc
index 7afd64cd5ee485a148d10cd9665bf890328dc934..0a04d60d76934e105eaf93845a0edb9562ac289b 100644
--- a/chrome/browser/search/most_visited_iframe_source.cc
+++ b/chrome/browser/search/most_visited_iframe_source.cc
@@ -35,6 +35,8 @@ MostVisitedIframeSource::~MostVisitedIframeSource() {
const int MostVisitedIframeSource::kNumMostVisited = 8;
const char MostVisitedIframeSource::kMostVisitedHistogramName[] =
"NewTabPage.MostVisited";
+const char MostVisitedIframeSource::kMostVisitedHistogramWithProvider[] =
+ "NewTabPage.MostVisited.%s";
std::string MostVisitedIframeSource::GetSource() const {
return chrome::kChromeSearchMostVisitedHost;
@@ -69,8 +71,14 @@ void MostVisitedIframeSource::StartDataRequest(
int position;
if (net::GetValueForKeyInQuery(url, "pos", &str_position) &&
base::StringToInt(str_position, &position)) {
- UMA_HISTOGRAM_ENUMERATION(kMostVisitedHistogramName, position,
- kNumMostVisited);
+ // Log the Most Visited click.
+ MV_CLICK_HISTOGRAM(position, NULL);
+ // If a specific provider is specified, log the metric specific to the
+ // provider.
+ std::string provider;
+ if (net::GetValueForKeyInQuery(url, "pr", &provider)) {
+ MV_CLICK_HISTOGRAM(position, provider.c_str());
+ }
// Records the action. This will be available as a time-stamped stream
// server-side and can be used to compute time-to-long-dwell.
content::RecordAction(content::UserMetricsAction("MostVisited_Clicked"));

Powered by Google App Engine
This is Rietveld 408576698