[Most Visited] Log suggestion provider to UMA

chrome/browser/search/most_visited_iframe_source.h

Index: chrome/browser/search/most_visited_iframe_source.h
diff --git a/chrome/browser/search/most_visited_iframe_source.h b/chrome/browser/search/most_visited_iframe_source.h
index 7344cc82724f920054e914ea0979733c0f9cd663..ca63471e59408f14f9b9897df3ca7510af89f6ce 100644
--- a/chrome/browser/search/most_visited_iframe_source.h
+++ b/chrome/browser/search/most_visited_iframe_source.h
@@ -7,6 +7,7 @@
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
+#include "base/gtest_prod_util.h"
 #include "chrome/browser/search/iframe_source.h"
 
 // Serves HTML for displaying suggestions using iframes, e.g.
@@ -34,6 +35,18 @@ class MostVisitedIframeSource : public IframeSource {
 
   virtual bool ServesPath(const std::string& path) const OVERRIDE;
 
+ private:
+  FRIEND_TEST_ALL_PREFIXES(MostVisitedIframeSourceTest,
+                           LogEndpointIsValidWithProvider);
+  // Logs the click on a Most Visited tile for a specific |provider|. Note that

[Alexei Svitkine (slow), 2013/12/13 20:12:49]

Nit: Add an empty line before that.

[Mathieu, 2013/12/13 20:17:56]

Done.

+  // the UMA_HISTOGRAM_ENUMERATION macro cannot be used since it caches the
+  // histogram object at the call site, which will not work in this case.
+  void LogMostVisitedProviderClick(int position, const std::string& provider);
+
+  // Returns the name of the histogram that should be logged for a click to a
+  // specified Most Visited |provider|.
+  static std::string GetHistogramNameForProvider(const std::string& provider);
+
   DISALLOW_COPY_AND_ASSIGN(MostVisitedIframeSource);
 };