[Most Visited] Log suggestion provider to UMA

chrome/browser/resources/local_ntp/most_visited_util.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 
 /**
  * @fileoverview Utilities for rendering most visited thumbnails and titles.
  */
 
 <include src="instant_iframe_validation.js">
@@ skipping 52 matching lines @@
 
 /**
  * Creates a new most visited link element.
  * @param {Object} params URL parameters containing styles for the link.
  * @param {string} href The destination for the link.
  * @param {string} title The title for the link.
  * @param {string|undefined} text The text for the link or none.
  * @param {string|undefined} ping If specified, a location relative to the
  *     referrer of this iframe, to ping when the link is clicked. Only works if
  *     the referrer is HTTPS.
+ * @param {string|undefined} provider A provider name (max 8 alphanumeric
+ *     characters) used for logging. Undefined if suggestion is not coming from
+ *     the server.
  * @return {HTMLAnchorElement} A new link element.
  */
-function createMostVisitedLink(params, href, title, text, ping) {
+function createMostVisitedLink(params, href, title, text, ping, provider) {
   var styles = getMostVisitedStyles(params, !!text);
   var link = document.createElement('a');
   link.style.color = styles.color;
   link.style.fontSize = styles.fontSize + 'px';
   if (styles.fontFamily)
     link.style.fontFamily = styles.fontFamily;
   link.href = href;
   if ('pos' in params && isFinite(params.pos)) {
     link.ping = '/log.html?pos=' + params.pos;
+    if (provider)
+      link.ping += '&pr=' + provider;
     // If a ping parameter was specified, add it to the list of pings, relative
     // to the referrer of this iframe, which is the default search provider.
     if (ping) {
       var parentUrl = document.createElement('a');
       parentUrl.href = document.referrer;
       if (parentUrl.protocol == 'https:') {
         link.ping += ' ' + parentUrl.origin + '/' + ping;
       }
     }
   }
@@ skipping 60 matching lines @@
   var data = {};
   if (params.url) {
     // Means that the suggestion data comes from the server. Create data object.
     data.url = params.url;
     data.thumbnailUrl = params.tu || '';
     data.thumbnailUrl2 = params.tu2 || '';
     data.title = params.ti || '';
     data.direction = params.di || '';
     data.domain = params.dom || '';
     data.ping = params.ping || '';
+    data.provider = params.pr || '';

[beaudoin, 2013/12/12 19:37:21]

I suggest:
  params.pr || SERVER;
With SERVER being a precanned string indicating a generic server provider. I'd
say "server".

[Mathieu, 2013/12/12 21:39:13]

Done.

     // Log the fact that suggestion was obtained from the server.
     var ntpApiHandle = chrome.embeddedSearch.newTabPage;
     ntpApiHandle.logEvent(NTP_LOGGING_EVENT_TYPE.NTP_SERVER_SIDE_SUGGESTION);
   } else {
     var apiHandle = chrome.embeddedSearch.searchBox;
     data = apiHandle.getMostVisitedItemData(params.rid);
     if (!data)
       return;

[beaudoin, 2013/12/12 19:37:21]

I suggest adding:
data.provider = CLIENT
(see above)

[Mathieu, 2013/12/12 21:39:13]

Done.

     delete data.ping;
   }
   if (/^javascript:/i.test(data.url) ||
       /^javascript:/i.test(data.thumbnailUrl) ||
-      /^javascript:/i.test(data.thumbnailUrl2))
+      /^javascript:/i.test(data.thumbnailUrl2) ||
+      (data.provider && !/^[a-z0-9]{0,8}$/i.test(data.provider)))
     return;
   if (data.direction)
     document.body.dir = data.direction;
   fill(params, data);
 }