Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1114213005: Convert SpdyNetworkTransactionTest to SequencedSocketData. (Closed)

Created:
5 years, 7 months ago by Ryan Hamilton
Modified:
5 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert SpdyNetworkTransactionTest to SequencedSocketData. Reduces runtime to 11 seconds from 59 seconds on my linux workstation. There are still a number of tests which have not been unconverted because they make use of "CompleteRead" semantics which I still need to implement in SequencedSocketData. BUG=332112 Committed: https://crrev.com/73e1742f4729161d16f70cbdad9d4c1c1836be52 Cr-Commit-Position: refs/heads/master@{#328171} Committed: https://crrev.com/08e3aa3e2c6b792a585ca011ad490f9263756197 Cr-Commit-Position: refs/heads/master@{#330287}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : always use writes #

Patch Set 4 : Rebase #

Patch Set 5 : Format #

Total comments: 4

Patch Set 6 : fix comments #

Patch Set 7 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+483 lines, -584 lines) Patch
M net/spdy/spdy_network_transaction_unittest.cc View 1 2 3 4 5 6 120 chunks +483 lines, -584 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Ryan Hamilton
5 years, 7 months ago (2015-05-01 21:39:25 UTC) #2
ramant (doing other things)
lgtm Excellent. Thanks for doing this. https://codereview.chromium.org/1114213005/diff/80001/net/spdy/spdy_network_transaction_unittest.cc File net/spdy/spdy_network_transaction_unittest.cc (right): https://codereview.chromium.org/1114213005/diff/80001/net/spdy/spdy_network_transaction_unittest.cc#newcode1744 net/spdy/spdy_network_transaction_unittest.cc:1744: MockWrite(ASYNC, 0, 0) ...
5 years, 7 months ago (2015-05-01 22:03:13 UTC) #3
Ryan Hamilton
Thanks! https://codereview.chromium.org/1114213005/diff/80001/net/spdy/spdy_network_transaction_unittest.cc File net/spdy/spdy_network_transaction_unittest.cc (right): https://codereview.chromium.org/1114213005/diff/80001/net/spdy/spdy_network_transaction_unittest.cc#newcode1744 net/spdy/spdy_network_transaction_unittest.cc:1744: MockWrite(ASYNC, 0, 0) // EOF On 2015/05/01 22:03:13, ...
5 years, 7 months ago (2015-05-03 14:13:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1114213005/120001
5 years, 7 months ago (2015-05-04 18:44:21 UTC) #8
commit-bot: I haz the power
Committed patchset #6 (id:120001)
5 years, 7 months ago (2015-05-04 19:52:15 UTC) #9
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/73e1742f4729161d16f70cbdad9d4c1c1836be52 Cr-Commit-Position: refs/heads/master@{#328171}
5 years, 7 months ago (2015-05-04 19:53:36 UTC) #10
Dan Beam
A revert of this CL (patchset #6 id:120001) has been created in https://codereview.chromium.org/1126763002/ by dbeam@chromium.org. ...
5 years, 7 months ago (2015-05-05 03:36:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1114213005/140001
5 years, 7 months ago (2015-05-16 14:00:02 UTC) #14
commit-bot: I haz the power
Committed patchset #7 (id:140001)
5 years, 7 months ago (2015-05-16 14:28:04 UTC) #15
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:31:53 UTC) #16
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/08e3aa3e2c6b792a585ca011ad490f9263756197
Cr-Commit-Position: refs/heads/master@{#330287}

Powered by Google App Engine
This is Rietveld 408576698