Add pexpect-2.3 to third_party

Add pexpect-2.3 to third_party

BUG=154343
NOTRY=True

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162303

[nduca, 2012-10-16 03:47:26]

First step in making forwarder and other android scripts work on mac.

[nduca, 2012-10-16 03:48:11]

+phajdan.jr for advice on how to deal with lack of license text in the sources.

http://www.chromium.org/developers/adding-3rd-party-libraries is unclear on what
to do when your upstream codebase doesn't use license headers and its not
practical to get them added.

[Isaac (away), 2012-10-16 04:01:03]

Drive by comment:

Please make sure to add README.chromium and LICENSE files or you will break the
android bot.

Otherwise, looks good!  Will let the other reviewers give the final OK.

[nduca, 2012-10-16 04:43:18]

Yep, the license file is there, but until I can sort out what to do about
checklicenses, failures this is a sitting duck.

[bulach, 2012-10-16 09:57:01]

thanks nat! looks fine by me, but I think you also need to add
open-source-third-party-reviews@google.com as reviewer..

[Paweł Hajdan Jr., 2012-10-16 17:10:07]

http://codereview.chromium.org/11142035/diff/3002/tools/checklicenses/checkli...
File tools/checklicenses/checklicenses.py (right):

http://codereview.chromium.org/11142035/diff/3002/tools/checklicenses/checkli...
tools/checklicenses/checklicenses.py:318: 'third_party/pexpect': [
This should link to an upstream bug about missing license headers. Why would it
be impractical to add them?

[nduca, 2012-10-16 17:17:04]

> This should link to an upstream bug about missing license headers.

I'll file a bug.

> Why would it be impractical to add them?

I will file a bug and we can try to remove the restriction as a followup. There
are two years of commits between the 2.3 release and ToT, all of which need to
be verified against ToT. I have an email thread outstanding with the author of
pexpect trying to get the headers added, hopefully he'll respond.

[nduca, 2012-10-16 17:17:37]

+open-source-third-party-reviews

[Paweł Hajdan Jr., 2012-10-16 21:34:28]

LGTM

[nduca, 2012-10-17 02:39:42]

Checked offline about the licensing issues. We should be good to land.

[commit-bot: I haz the power, 2012-10-17 02:40:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nduca@chromium.org/11142035/19001

[commit-bot: I haz the power, 2012-10-17 02:57:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nduca@chromium.org/11142035/19001

[commit-bot: I haz the power, 2012-10-17 02:58:47]

Change committed as 162303