Chromium Code Reviews
Help | Chromium Project | Sign in
(187)

Issue 11142029: Merge 161369 - Clear source_id_{audio,video}_ after RemoveId. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by acolwell
Modified:
1 year, 6 months ago
Reviewers:
strobe_
CC:
chromium-reviews_chromium.org, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Merge 161369 - Clear source_id_{audio,video}_ after RemoveId.

After adding a source buffer and then immediately removing it, new source
buffers containing the same content component couldn't be added to the same
MediaSource object. Such a pattern could be used as an ad-hoc canPlayType()
for Media Source. This fixes.

BUG=155226
TEST=ChunkDemuxer.TestRemoveAndAddId


Review URL: https://chromiumcodereview.appspot.com/11088067

TBR=strobe@google.com
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=162009

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -4 lines) Lint Patch
M media/filters/chunk_demuxer.cc View 1 chunk +10 lines, -4 lines 0 comments 0 errors Download
M media/filters/chunk_demuxer_unittest.cc View 1 chunk +11 lines, -0 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 2
acolwell
1 year, 6 months ago #1
strobe_
1 year, 6 months ago #2
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6