Chromium Code Reviews
Help | Chromium Project | Sign in
(1)

Issue 11142029: Merge 161369 - Clear source_id_{audio,video}_ after RemoveId. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 5 months ago by acolwell GONE FROM CHROMIUM
Modified:
2 years, 5 months ago
Reviewers:
strobe_
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Merge 161369 - Clear source_id_{audio,video}_ after RemoveId. After adding a source buffer and then immediately removing it, new source buffers containing the same content component couldn't be added to the same MediaSource object. Such a pattern could be used as an ad-hoc canPlayType() for Media Source. This fixes. BUG=155226 TEST=ChunkDemuxer.TestRemoveAndAddId Review URL: https://chromiumcodereview.appspot.com/11088067 TBR=strobe@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=162009

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -4 lines) Patch
M media/filters/chunk_demuxer.cc View 1 chunk +10 lines, -4 lines 0 comments Download
M media/filters/chunk_demuxer_unittest.cc View 1 chunk +11 lines, -0 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 2 (0 generated)
acolwell GONE FROM CHROMIUM
2 years, 5 months ago (2012-10-16 00:08:32 UTC) #1
strobe_
2 years, 5 months ago (2012-10-16 00:09:30 UTC) #2
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cf4c24d