Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 1114193003: PPC: [turbofan] Fix tail call optimization. (Closed)

Created:
5 years, 7 months ago by MTBrandyberry
Modified:
5 years, 7 months ago
Reviewers:
michael_dawson, dstence
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [turbofan] Fix tail call optimization. Port d21de2a48bc63823876d3f9bf52753f9da0aea6b Original commit message: Tail calls are matched on the graph, with a dedicated tail call optimization that is actually testable. The instruction selection can still fall back to a regular if the platform constraints don't allow to emit a tail call (i.e. the return locations of caller and callee differ or the callee takes non-register parameters, which is a restriction that will be removed in the future). Also explicitly limit tail call optimization to stubs for now and drop the global flag. R=dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/38f7ccba791ea11b10df1c5dfa79bb52c1c441f3 Cr-Commit-Position: refs/heads/master@{#28239}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -14 lines) Patch
M src/compiler/ppc/instruction-selector-ppc.cc View 3 chunks +94 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
MTBrandyberry
5 years, 7 months ago (2015-05-05 17:28:52 UTC) #1
dstence
lgtm
5 years, 7 months ago (2015-05-05 17:32:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1114193003/1
5 years, 7 months ago (2015-05-05 17:35:26 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-05 18:07:16 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 18:07:32 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/38f7ccba791ea11b10df1c5dfa79bb52c1c441f3
Cr-Commit-Position: refs/heads/master@{#28239}

Powered by Google App Engine
This is Rietveld 408576698