Issue 1114123003: Fix various missing dependencies in //components for the Mac GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1114123003: Fix various missing dependencies in //components for the Mac GN build. (Closed)

Created:
5 years, 7 months ago by Dirk Pranke

Modified:
5 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@content_shell_lib

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Fix various missing dependencies in //components for the Mac GN build. TBR=brettw@chromium.org BUG=431177 CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Committed: https://crrev.com/07af333a0a2c0672bd8f4f6fb6601c36fb3c833f Cr-Commit-Position: refs/heads/master@{#327862}

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -0 lines)			Patch
M	components/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	components/autofill/core/browser/BUILD.gn	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	components/wifi/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 5 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1114123003/1

5 years, 7 months ago (2015-05-01 01:19:37 UTC) #3

commit-bot: I haz the power

5 years, 7 months ago (2015-05-01 01:47:33 UTC) #5

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/07af333a0a2c0672bd8f4f6fb6601c36fb3c833f
Cr-Commit-Position: refs/heads/master@{#327862}