Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 1114103003: Allow delta links for large files but give appropriate error message when viewing (Closed)

Created:
5 years, 7 months ago by jrobbins
Modified:
5 years, 7 months ago
Reviewers:
rmistry, rmistry1
CC:
chromium-reviews, rmistry+cc_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Allow delta links for large files but give appropriate error message when viewing R=rmistry@google.com, rmistry@chromium.org BUG=482820 Committed: https://chromium.googlesource.com/infra/rietveld/+/d9604e772402544425f99588dc87513f728c6223

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M appengine/chromium_rietveld/codereview/models.py View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jrobbins
PTAL. I think what happened (over 2 years ago) is that the decision was made ...
5 years, 7 months ago (2015-04-30 18:15:52 UTC) #1
rmistry
LGTM
5 years, 7 months ago (2015-04-30 18:26:34 UTC) #3
jrobbins
5 years, 7 months ago (2015-04-30 19:05:44 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d9604e772402544425f99588dc87513f728c6223.

Powered by Google App Engine
This is Rietveld 408576698