|
|
Created:
5 years, 7 months ago by wychen Modified:
5 years, 6 months ago CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master Target Ref:
refs/heads/master Project:
tools Visibility:
Public. |
DescriptionShow date format in help message in my_activity.py
It was not very obvious what kind of date format is expected.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295448
Patch Set 1 #
Messages
Total messages: 22 (9 generated)
wychen@chromium.org changed reviewers: + cjhopman@chromium.org
PTAL
lgtm
The CQ bit was checked by wychen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1114093004/1
The CQ bit was unchecked by commit-bot@chromium.org
Presubmit check for 1114093004-1 failed and returned exit status 1. Running presubmit commit checks ... Initialized empty Git repository in /b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/_rietveld/.git/ Updating origin From https://chromium.googlesource.com/infra/infra * [new branch] deployed -> origin/deployed * [new branch] master -> origin/master From https://chromium.googlesource.com/infra/infra * branch master -> FETCH_HEAD Checking out rietveld... Running save-description-on-failure.sh Running push-basic.sh Running upstream.sh Running submit-from-new-dir.sh Running abandon.sh Running submodule-merge-test.sh Running upload-local-tracking-branch.sh Running hooks.sh Running post-dcommit-hook-test.sh Running upload-stale.sh Running patch.sh Running basic.sh ** Presubmit ERRORS ** Missing LGTM from an OWNER for these files: depot_tools/my_activity.py tests/git_rebase_update_test.py (11.59s) failed .Switched to branch foobar. Switched to branch sub_K. Switched to branch old_branch. Switched to branch empty_branch. Switched to branch empty_branch2. FSwitched to branch foobar. . ====================================================================== FAIL: testRebaseUpdate (__main__.GitRebaseUpdateTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "tests/git_rebase_update_test.py", line 207, in testRebaseUpdate 'branch_L', 'old_branch', 'foobar'}) AssertionError: Items in the first set but not the second: 'origin/master)' ---------------------------------------------------------------------- Ran 3 tests in 11.389s FAILED (failures=1) Name Stmts Miss Cover Missing --------------------------------------------------- git_new_branch 28 0 100% git_rebase_update 144 0 100% git_rename_branch 29 0 100% git_reparent_branch 43 0 100% --------------------------------------------------- TOTAL 244 0 100% tests/git_common_test.py (5.97s) failed ...x....F.....FF........uCannot foo with a dirty tree. You must commit locally first. Uncommitted files: (git diff-index --name-status HEAD) A test.file ....... ====================================================================== FAIL: testGetBranchTree (__main__.GitMutableStructuredTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "tests/git_common_test.py", line 536, in testGetBranchTree self.assertEqual(skipped, {'master', 'root_X', 'branch_DOG', 'root_CAT'}) AssertionError: Items in the first set but not the second: '78df7e3)' ====================================================================== FAIL: testTooManyBranches (__main__.GitMutableStructuredTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "tests/git_common_test.py", line 464, in testTooManyBranches self.assertEqual(38, len(self.repo.run(list, self.gc.branches()))) AssertionError: 38 != 39 ====================================================================== FAIL: testBranches (__main__.GitReadOnlyFunctionsTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "tests/git_common_test.py", line 235, in testBranches {'master', 'branch_D', 'root_A'}) AssertionError: Items in the first set but not the second: '696a838)' ---------------------------------------------------------------------- Ran 32 tests in 5.814s FAILED (failures=3, expected failures=1, unexpected successes=1) Name Stmts Miss Cover Missing ------------------------------------------ git_common 388 19 95% 319, 683-706 FATAL: not at 100% coverage. Presubmit checks took 178.4s to calculate.
wychen@chromium.org changed reviewers: + dpranke@chromium.org
+dpranke for owner review
lgtm
The CQ bit was checked by wychen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1114093004/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Presubmit check for 1114093004-1 failed and returned exit status 1. Running presubmit commit checks ... Initialized empty Git repository in /b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/_rietveld/.git/ Updating origin From https://chromium.googlesource.com/infra/infra * [new branch] deployed -> origin/deployed * [new branch] master -> origin/master From https://chromium.googlesource.com/infra/infra * branch master -> FETCH_HEAD Checking out rietveld... Running save-description-on-failure.sh Running push-basic.sh Running upstream.sh Running submit-from-new-dir.sh Running abandon.sh Running submodule-merge-test.sh Running upload-local-tracking-branch.sh Running hooks.sh Running post-dcommit-hook-test.sh Running upload-stale.sh Running patch.sh Running basic.sh ** Presubmit ERRORS ** tests/git_rebase_update_test.py (13.90s) failed .Switched to branch foobar. Switched to branch sub_K. Switched to branch old_branch. Switched to branch empty_branch. Switched to branch empty_branch2. FSwitched to branch foobar. . ====================================================================== FAIL: testRebaseUpdate (__main__.GitRebaseUpdateTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "tests/git_rebase_update_test.py", line 207, in testRebaseUpdate 'branch_L', 'old_branch', 'foobar'}) AssertionError: Items in the first set but not the second: 'origin/master)' ---------------------------------------------------------------------- Ran 3 tests in 13.681s FAILED (failures=1) Name Stmts Miss Cover Missing --------------------------------------------------- git_new_branch 28 0 100% git_rebase_update 144 0 100% git_rename_branch 29 0 100% git_reparent_branch 43 0 100% --------------------------------------------------- TOTAL 244 0 100% tests/git_common_test.py (7.09s) failed ...x....F.....FF........uCannot foo with a dirty tree. You must commit locally first. Uncommitted files: (git diff-index --name-status HEAD) A test.file ....... ====================================================================== FAIL: testGetBranchTree (__main__.GitMutableStructuredTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "tests/git_common_test.py", line 536, in testGetBranchTree self.assertEqual(skipped, {'master', 'root_X', 'branch_DOG', 'root_CAT'}) AssertionError: Items in the first set but not the second: '78df7e3)' ====================================================================== FAIL: testTooManyBranches (__main__.GitMutableStructuredTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "tests/git_common_test.py", line 464, in testTooManyBranches self.assertEqual(38, len(self.repo.run(list, self.gc.branches()))) AssertionError: 38 != 39 ====================================================================== FAIL: testBranches (__main__.GitReadOnlyFunctionsTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "tests/git_common_test.py", line 235, in testBranches {'master', 'branch_D', 'root_A'}) AssertionError: Items in the first set but not the second: '696a838)' ---------------------------------------------------------------------- Ran 32 tests in 6.831s FAILED (failures=3, expected failures=1, unexpected successes=1) Name Stmts Miss Cover Missing ------------------------------------------ git_common 388 19 95% 319, 683-706 FATAL: not at 100% coverage. Presubmit checks took 182.3s to calculate. Was the presubmit check useful? If not, run "git cl presubmit -v" to figure out which PRESUBMIT.py was run, then run git blame on the file to figure out who to ask for help.
Strangely I couldn't reproduce the presubmit failure. I tried on both my branch and origin/master, and they passed.
The CQ bit was checked by wychen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1114093004/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Presubmit check for 1114093004-1 failed and returned exit status 1. Running presubmit commit checks ... Initialized empty Git repository in /b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/_rietveld/.git/ Updating origin From https://chromium.googlesource.com/infra/infra * [new branch] deployed -> origin/deployed * [new branch] master -> origin/master From https://chromium.googlesource.com/infra/infra * branch master -> FETCH_HEAD Checking out rietveld... Running save-description-on-failure.sh Running push-basic.sh Running upstream.sh Running submit-from-new-dir.sh Running abandon.sh Running submodule-merge-test.sh Running upload-local-tracking-branch.sh Running hooks.sh Running post-dcommit-hook-test.sh Running upload-stale.sh Running patch.sh Running basic.sh ** Presubmit ERRORS ** tests/git_rebase_update_test.py (12.39s) failed .Switched to branch foobar. Switched to branch sub_K. Switched to branch old_branch. Switched to branch empty_branch. Switched to branch empty_branch2. FSwitched to branch foobar. . ====================================================================== FAIL: testRebaseUpdate (__main__.GitRebaseUpdateTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "tests/git_rebase_update_test.py", line 207, in testRebaseUpdate 'branch_L', 'old_branch', 'foobar'}) AssertionError: Items in the first set but not the second: 'origin/master)' ---------------------------------------------------------------------- Ran 3 tests in 12.142s FAILED (failures=1) Name Stmts Miss Cover Missing --------------------------------------------------- git_new_branch 28 0 100% git_rebase_update 144 0 100% git_rename_branch 29 0 100% git_reparent_branch 43 0 100% --------------------------------------------------- TOTAL 244 0 100% tests/git_common_test.py (6.33s) failed ...x....F.....FF........uCannot foo with a dirty tree. You must commit locally first. Uncommitted files: (git diff-index --name-status HEAD) A test.file ....... ====================================================================== FAIL: testGetBranchTree (__main__.GitMutableStructuredTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "tests/git_common_test.py", line 536, in testGetBranchTree self.assertEqual(skipped, {'master', 'root_X', 'branch_DOG', 'root_CAT'}) AssertionError: Items in the first set but not the second: '78df7e3)' ====================================================================== FAIL: testTooManyBranches (__main__.GitMutableStructuredTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "tests/git_common_test.py", line 464, in testTooManyBranches self.assertEqual(38, len(self.repo.run(list, self.gc.branches()))) AssertionError: 38 != 39 ====================================================================== FAIL: testBranches (__main__.GitReadOnlyFunctionsTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "tests/git_common_test.py", line 235, in testBranches {'master', 'branch_D', 'root_A'}) AssertionError: Items in the first set but not the second: '696a838)' ---------------------------------------------------------------------- Ran 32 tests in 6.071s FAILED (failures=3, expected failures=1, unexpected successes=1) Name Stmts Miss Cover Missing ------------------------------------------ git_common 388 19 95% 319, 683-706 FATAL: not at 100% coverage. Presubmit checks took 176.2s to calculate.
The CQ bit was checked by wychen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1114093004/1
Message was sent while issue was closed.
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=295448 |