Add a content API to connect a Native Client module to an out-of-process PPAPI proxy.

content/renderer/pepper/pepper_plugin_delegate_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/pepper/pepper_plugin_delegate_impl.h"
 
 #include <cmath>
 #include <cstddef>
 #include <map>
 #include <queue>
@@ skipping 396 matching lines @@
 
   RendererPpapiHostImpl* host_impl =
       content::RendererPpapiHostImpl::CreateOnModuleForOutOfProcess(
           module, dispatcher->dispatcher(), permissions);
   render_view_->PpapiPluginCreated(host_impl);
 
   module->InitAsProxied(dispatcher.release());
   return module;
 }
 
+RendererPpapiHost* PepperPluginDelegateImpl::CreateExternalPluginModule(
+    scoped_refptr<webkit::ppapi::PluginModule> plugin_module,
+    const FilePath& file_path,
+    ppapi::PpapiPermissions permissions,
+    const IPC::ChannelHandle& channel_handle,
+    int child_process_id) {
+  scoped_refptr<PepperHungPluginFilter> hung_filter(

[brettw, 2012/10/16 23:37:32]

This code is just copied and pasted from the previous function. If you moved the
PluginModule creation above, I think you could just factor this into a helper
function to start a proxy on a given plugin module.

[bbudge, 2012/10/17 00:18:44]

Done. Good eye.

+      new PepperHungPluginFilter(file_path,
+                                 render_view_->routing_id(),
+                                 child_process_id));
+  // Create a new HostDispatcher for the proxy, and hook it up to the
+  // plugin module.
+  scoped_ptr<HostDispatcherWrapper> dispatcher(
+      new HostDispatcherWrapper(plugin_module,
+                                child_process_id,
+                                permissions));
+  if (!dispatcher->Init(
+          channel_handle,
+          webkit::ppapi::PluginModule::GetLocalGetInterfaceFunc(),
+          GetPreferences(),
+          permissions,
+          hung_filter.get()))
+    return NULL;
+
+  RendererPpapiHostImpl* host_impl =
+      content::RendererPpapiHostImpl::CreateOnModuleForOutOfProcess(

[jam, 2012/10/16 21:14:43]

nit: no need for content::

[bbudge, 2012/10/17 00:18:44]

Done.

+          plugin_module, dispatcher->dispatcher(), permissions);
+  render_view_->PpapiPluginCreated(host_impl);
+
+  plugin_module->InitAsProxied(dispatcher.release());
+
+  return host_impl;
+}
+
 scoped_refptr<webkit::ppapi::PluginModule>
     PepperPluginDelegateImpl::CreateBrowserPluginModule(
         const IPC::ChannelHandle& channel_handle,
         int guest_process_id) {
   content::old::BrowserPluginRegistry* registry =
       RenderThreadImpl::current()->browser_plugin_registry();
   scoped_refptr<webkit::ppapi::PluginModule> module =
       registry->GetModule(guest_process_id);
   if (module)
     return module;
@@ skipping 1433 matching lines @@
   else
     return render_view_->mouse_lock_dispatcher();
 }
 
 webkit_glue::ClipboardClient*
     PepperPluginDelegateImpl::CreateClipboardClient() const {
   return new RendererClipboardClient;
 }
 
 }  // namespace content