Change Windows build default to build with Visual Studio 2010.

Change Windows build default to build with Visual Studio 2010.

[Bob Nystrom, 2012-10-15 19:01:38]

One suggestion, but LGTM!

https://codereview.chromium.org/11140033/diff/1/tools/build.py
File tools/build.py (right):

https://codereview.chromium.org/11140033/diff/1/tools/build.py#newcode45
tools/build.py:45: default='C:\\Program Files (x86)\\Microsoft Visual Studio
10.0\\Common7\\IDE')
Long line. Also, how about including the executable name here too instead of
hard-coding that later so that you can pass in VCExpress.exe?

[Johnni Winther, 2012-10-15 21:30:20]

lgtm

[Emily Fortuna, 2012-10-16 20:25:23]

Bob, PTAL -- to make sure this is along the lines of your suggestion?

[Bob Nystrom, 2012-10-16 20:27:52]

LGTM!

https://codereview.chromium.org/11140033/diff/10001/tools/build.py
File tools/build.py (right):

https://codereview.chromium.org/11140033/diff/10001/tools/build.py#newcode49
tools/build.py:49: '(varies for different versions of Visual Studio)',
default='devenv.com')
"(varies for" is repeated.

[Emily Fortuna, 2012-10-16 21:29:11]

FYI: this was actually committed with this CL:
https://codereview.chromium.org/11184008/ because I Windows 8 was not playing
nicely with the dart svn checkout.

[Jennifer Messerly, 2012-10-16 22:07:00]

https://codereview.chromium.org/11140033/diff/12002/tools/build.py
File tools/build.py (right):

https://codereview.chromium.org/11140033/diff/12002/tools/build.py#newcode45
tools/build.py:45: default='C:\\Program Files (x86)\\Microsoft Visual Studio
10.0\\Common7'
IIRC, there's an environment variable for Program Files. (type "set" to see the
variables)

Also there's a registry key (and an environment variable?) to detect the VS
install path. That's the canonical way to do it.

[ricow1, 2012-10-18 06:22:04]

https://codereview.chromium.org/11140033/diff/12002/tools/build.py
File tools/build.py (right):

https://codereview.chromium.org/11140033/diff/12002/tools/build.py#newcode45
tools/build.py:45: default='C:\\Program Files (x86)\\Microsoft Visual Studio
10.0\\Common7'
On 2012/10/16 22:07:00, John Messerly wrote:
> IIRC, there's an environment variable for Program Files. (type "set" to see
the
> variables)
> 
> Also there's a registry key (and an environment variable?) to detect the VS
> install path. That's the canonical way to do it.
John is right, for easy retrieval of this take a look in
build/scripts/slave/compile.py
in the buildbot source