Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1114003002: Replace the RepeatingTimer in ImageDecoder with a DelayTimer. (Closed)

Created:
5 years, 7 months ago by Lei Zhang
Modified:
5 years, 7 months ago
CC:
chromium-reviews, Theresa
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace the RepeatingTimer in ImageDecoder with a DelayTimer. Committed: https://crrev.com/d3485b693c1106dbe2b1258fc0ad097d32ad52cf Cr-Commit-Position: refs/heads/master@{#327688}

Patch Set 1 #

Total comments: 1

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -16 lines) Patch
M chrome/browser/image_decoder.h View 1 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/image_decoder.cc View 3 chunks +10 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Lei Zhang
4, 8, 15, 16, 23, 42...
5 years, 7 months ago (2015-04-30 05:51:44 UTC) #2
Anand Mistry (off Chromium)
LGTM Net diff, -4 lines. Yay! https://codereview.chromium.org/1114003002/diff/1/chrome/browser/image_decoder.h File chrome/browser/image_decoder.h (right): https://codereview.chromium.org/1114003002/diff/1/chrome/browser/image_decoder.h#newcode144 chrome/browser/image_decoder.h:144: // Calls StopBatchMode() ...
5 years, 7 months ago (2015-04-30 06:14:43 UTC) #3
Lei Zhang
On 2015/04/30 06:14:43, Anand Mistry wrote: > LGTM > > Net diff, -4 lines. Yay! ...
5 years, 7 months ago (2015-04-30 08:11:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1114003002/20001
5 years, 7 months ago (2015-04-30 08:12:08 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-04-30 09:47:42 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 09:48:25 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d3485b693c1106dbe2b1258fc0ad097d32ad52cf
Cr-Commit-Position: refs/heads/master@{#327688}

Powered by Google App Engine
This is Rietveld 408576698